unittest: fix class instances no longer released on test teardown since pytest 8.2.0 #12368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
commented
May 25, 2024
| @@ -192,30 +191,32 @@ def test_check(self): | |||
| def test_teardown_issue1649(pytester: Pytester) -> None: | |||
There was a problem hiding this comment.
The way this test was written previously wasn't good; it checked if the obj is still alive after the pytester run, at which the entire session was torn down, too late. This fixes it up. I made sure it now fails before and passes after.
bluetech
commented
May 25, 2024
| @@ -218,11 +218,12 @@ def setup(self) -> None: | |||
| super().setup() | |||
|
|
|||
| def teardown(self) -> None: | |||
| super().teardown() | |||
There was a problem hiding this comment.
This change isn't really related and doesn't have any effect because the super call doesn't do anything, but nonetheless teardown must be done in reverse order, so I fixed it just in case the super ever starts doing something.
nicoddemus
approved these changes
May 25, 2024
…ce pytest 8.2.0 Fix pytest-dev#12367.
bluetech
force-pushed
the
unittest-clear-instance
branch
from
ff9caa8
to
c3c5103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12367.