[prerelease] Attributes from legacypath plugin added too late?

[The-Compiler]

Based on joeyespo/pytest-watch#122 it seems impossible to access config.inifile from pytest_cmdline_main now.

Minimal reproducer conftest.py:

def pytest_cmdline_main(config):
    print(config.inifile)

fails after 84722a7 with:

[...]
  File ".../conftest.py", line 2, in pytest_cmdline_main
    print(config.inifile)
AttributeError: 'Config' object has no attribute 'inifile'

but works fine before.

This is part of Add legacypath plugin, move py.path stuff there by bluetech · Pull Request #9208 · pytest-dev/pytest, cc @bluetech.

Makes me wonder whether this plugin is really a good idea in practice, also seeing things like 663be09. Maybe those should be kept in core after all until we can deprecate and remove them, and only then be moved to a (rather hackish) plugin?

[nicoddemus]

Makes me wonder whether this plugin is really a good idea in practice

I particularly think so; it would be surprising such a change would work flawlessly from the get go, I believe we just need to iron out the last details.

[RonnyPfannschmidt]

we might want to use the plugin_registred hook to do some of the adjustments

[nicoddemus]

I'm on this. 👍

[nicoddemus]

#9400 is up