Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@cached_property is not checked for doctests #11237

Closed
4 tasks done
Lubba-64 opened this issue Jul 21, 2023 · 0 comments · Fixed by #11317
Closed
4 tasks done

@cached_property is not checked for doctests #11237

Lubba-64 opened this issue Jul 21, 2023 · 0 comments · Fixed by #11317
Labels
plugin: doctests related to the doctests builtin plugin type: bug problem that needs to be addressed

Comments

@Lubba-64
Copy link

Lubba-64 commented Jul 21, 2023

  • a detailed description of the bug or problem you are having
    If I have doctests in a function decorated with @cached_property, they will not be run.
  • output of pip list from the virtual environment you are using
Package           Version Editable project location
----------------- ------- ---------------------------------------------
coverage          6.5.0
exceptiongroup    1.1.2
iniconfig         2.0.0
nodeenv           1.8.0
packaging         23.1
pip               23.2
pluggy            1.2.0
pyright           1.1.318
pytest            7.4.0
setuptools        68.0.0
tomli             2.0.1
typing_extensions 4.7.1
wheel             0.38.4
  • pytest and operating system versions
    pytest 7.4.0
    Pop!_OS 22.04 LTS
  • minimal example if possible
from functools import cached_property

class Test:
    @cached_property
    def test_me(self):
        """
        A function that returns the string `ok`

        Examples
        --------
        >>> Test().test_me
        'ok'
        """
        return "ok"

    @property
    def test_me_2(self):
        """
        A function that returns the string `ok`

        Examples
        --------
        >>> Test().test_me_2
        'ok'
        """
        return "ok"

Run python -m pytest --doctest-modules, only one test will be captured and run.

@Zac-HD Zac-HD added type: bug problem that needs to be addressed plugin: doctests related to the doctests builtin plugin labels Jul 24, 2023
jsuchenia pushed a commit to jsuchenia/adventofcode that referenced this issue Dec 2, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [pytest](https://docs.pytest.org/en/latest/) ([source](https://github.com/pytest-dev/pytest), [changelog](https://docs.pytest.org/en/stable/changelog.html)) | patch | `==7.4.0` -> `==7.4.2` |

---

### Release Notes

<details>
<summary>pytest-dev/pytest (pytest)</summary>

### [`v7.4.2`](https://github.com/pytest-dev/pytest/releases/tag/7.4.2): pytest 7.4.2 (2023-09-07)

[Compare Source](pytest-dev/pytest@7.4.1...7.4.2)

### Bug Fixes

-   [#&#8203;11237](pytest-dev/pytest#11237): Fix doctest collection of `functools.cached_property` objects.

-   [#&#8203;11306](pytest-dev/pytest#11306): Fixed bug using `--importmode=importlib` which would cause package `__init__.py` files to be imported more than once in some cases.

-   [#&#8203;11367](pytest-dev/pytest#11367): Fixed bug where `user_properties` where not being saved in the JUnit XML file if a fixture failed during teardown.

-   [#&#8203;11394](pytest-dev/pytest#11394): Fixed crash when parsing long command line arguments that might be interpreted as files.

### Improved Documentation

-   [#&#8203;11391](pytest-dev/pytest#11391): Improved disclaimer on pytest plugin reference page to better indicate this is an automated, non-curated listing.

### [`v7.4.1`](https://github.com/pytest-dev/pytest/releases/tag/7.4.1): pytest 7.4.1 (2023-09-02)

[Compare Source](pytest-dev/pytest@7.4.0...7.4.1)

## Bug Fixes

-   [#&#8203;10337](pytest-dev/pytest#10337): Fixed bug where fake intermediate modules generated by `--import-mode=importlib` would not include the
    child modules as attributes of the parent modules.

-   [#&#8203;10702](pytest-dev/pytest#10702): Fixed error assertion handling in `pytest.approx` when `None` is an expected or received value when comparing dictionaries.

-   [#&#8203;10811](pytest-dev/pytest#10811): Fixed issue when using `--import-mode=importlib` together with `--doctest-modules` that caused modules
    to be imported more than once, causing problems with modules that have import side effects.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuMTA3LjIiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==-->

Reviewed-on: https://git.apud.pl/jacek/adventofcode/pulls/32
Co-authored-by: Renovate <renovate@apud.pl>
Co-committed-by: Renovate <renovate@apud.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: doctests related to the doctests builtin plugin type: bug problem that needs to be addressed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants