Teaching GNUFile methods to follow symlinks#751
Merged
Conversation
On Linux systems, if File.mode is used on a file that's a symlink, it will return 0x777 because that's the "mode" of the symlink but mode is pretty meaningless for a symlink. By doing `stat -L ...` the command will automatically resolve symlinks.
philpep
approved these changes
Feb 15, 2024
Contributor
|
Merged, thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux systems, if
File.modeis used on a file that's a symlink, it will return0x777because that's the mode of the symlink but mode is pretty meaningless for a symlink. By doingstat -L ...the command will automatically resolve symlinks.I know there is the BSDFile implementation too but I don't believe I have access to a BSD system to try things out.
This addresses a problem where testinfra is used to get information on a target file but you don't want to worry about whether a symbolic link is involved - it's irrelevant. There are examples of symlinks in the Amazon Linux 2023 container:
I ran the tests via
toxand they all passed.This is my first pytest-testinfra pull request and I would be happy to rework it however it needs to be done.