Skip to content

Update syntax to Python 3 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2022
Merged

Update syntax to Python 3 #36

merged 1 commit into from
May 13, 2022

Conversation

hramezani
Copy link
Member

No description provided.

@hramezani hramezani mentioned this pull request May 9, 2022
Closed
@diazona
Copy link
Contributor

diazona commented May 10, 2022

Thanks, this makes sense. Let's give it a while and see what the other maintainers say, if they see this anytime soon.

The addition of the badges seems out of place in this pull request... personally I would have split that to a separate PR, but it's not a big deal.

diazona
diazona reviewed May 10, 2022
View reviewed changes
@hramezani
Copy link
Member Author

The addition of the badges seems out of place in this pull request... personally I would have split that to a separate PR, but it's not a big deal.

As I keep it in a separate commit, I think you can merge the PR with a Rebase and Merge. Then we will have two separate commits.

@diazona
Copy link
Contributor

diazona commented May 10, 2022

As I keep it in a separate commit, I think you can merge the PR with a Rebase and Merge. Then we will have two separate commits.

Well, that wouldn't be consistent with the merge workflow we've been using. (Merge commits help keep track of features on master and keep the development history well organized.)

@hramezani hramezani changed the title Update syntax Update syntax to Python 3 May 10, 2022
@hramezani
Copy link
Member Author

@diazona I've removed the badges commit from this PR and created #38

@diazona diazona merged commit a1a4601 into pytest-dev:master May 13, 2022
RonnyPfannschmidt
RonnyPfannschmidt reviewed May 13, 2022
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommended trying shed/pyupgrade

@diazona diazona added this to the v0.7.0 milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt left review comments

@diazona diazona diazona left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hramezani @diazona @RonnyPfannschmidt