Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Table row hook #599

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Fix: Table row hook #599

merged 1 commit into from
Mar 20, 2023

Conversation

BeyondEvil
Copy link
Contributor

@BeyondEvil BeyondEvil commented Mar 19, 2023 •
edited
Loading

This PR fixes two things.

  • We broke backwards compat where you could do del cells[:] to remove an item from the report. This is an interim solution for that.
  • We also broke backwards compat where you could insert cells and have them sortable.

@BeyondEvil BeyondEvil changed the base branch from master to next-gen March 19, 2023 18:07
@BeyondEvil BeyondEvil changed the title Beyondevil/fix table row hook Fix: Table row hook Mar 19, 2023
@BeyondEvil BeyondEvil force-pushed the beyondevil/fix-table-row-hook branch from 1b8ec70 to 5034785 Compare March 19, 2023 19:57
@BeyondEvil BeyondEvil marked this pull request as ready for review March 19, 2023 20:00
@BeyondEvil BeyondEvil force-pushed the beyondevil/fix-table-row-hook branch from 5034785 to 15c8ce4 Compare March 19, 2023 20:05
@BeyondEvil BeyondEvil merged commit 40a80d5 into pytest-dev:next-gen Mar 20, 2023
@BeyondEvil BeyondEvil deleted the beyondevil/fix-table-row-hook branch March 20, 2023 13:33
BeyondEvil added a commit to BeyondEvil/pytest-html that referenced this pull request Apr 3, 2023
@BeyondEvil
fix: Table hooks (pytest-dev#599)
4bd7cee
@michalkaptur michalkaptur mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BeyondEvil