Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename master branch to main #560

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Conversation

ssbarnea
Copy link
Member

No description provided.

@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Oct 27, 2022
@ssbarnea ssbarnea merged commit 7da6a82 into pytest-dev:main Oct 27, 2022
@ssbarnea ssbarnea deleted the chore/branch branch October 27, 2022 13:37
BeyondEvil added a commit that referenced this pull request Oct 27, 2022
BeyondEvil added a commit that referenced this pull request Oct 27, 2022
@BeyondEvil
Copy link
Contributor

I've reverted this PR.

You do not merge a PR this disruptive without approval.

We can make this change once v4 (next-gen) has been released.

@ssbarnea
Copy link
Member Author

@BeyondEvil I would like to challenge you to explain what is disruptive about branch renaming? Over the last 2+ years, I did this on over a hundred of repos, and I am yet to see the what becomes disruptive.

@BeyondEvil
Copy link
Contributor

Every ref, fork and alias needs updating.

@ssbarnea
Copy link
Member Author

Apparently you are not aware about the fact that github redirects old name to new one, so you can still clone and pull from outdated urls. They did it quite well. Even the PR are kept open.

TBH; that is the first time when I see someone opposing that move. In fact before doing the rename I asked Ronny on irc about a possible wide move for the entire @pytest-dev so we could have consistent branch naming. Obviously that the wide move would need to be announced.

@BeyondEvil
Copy link
Contributor

BeyondEvil commented Oct 27, 2022

Will GH fix my aliases too?

This is my last response on this matter. You've sort of already proven my point about this being disruptive. It's also the most interaction I've gotten out of you for over a year.

If pytest-dev decides to do a wide rename, they can do it.

Until then, the rename won't happen until v4.

@RonnyPfannschmidt
Copy link
Member

ideally i want an eventual switch of all of pytest-dev to the "new" branch names,
however its important that its as painless as possible for the active maintainers of each repository

im fairly low on band-with for this myself for quite a while longer

i believe for pytest-html the most painless switchover will when v4 lands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants