Better fix for TerminalReporter issue

[BeyondEvil]

The issue with TerminalWriter in pytester is causing tests to fail.

[BeyondEvil]

Seems like Travis is having some issues. Will try again tomorrow.

[BeyondEvil]

@nicoddemus Sorry for spamming with reviewers, but this is blocking other PRs.

[nicoddemus]

If you mark the tests to filter warnings:

@pytest.mark.filterwarnings("ignore:.*TerminalReporter.writer.*")

You might not need remove_deprecation_from_recwarn in the end?

[BeyondEvil]

Tried it and it didn't work @nicoddemus

Maybe I'm doing something wrong?

    @pytest.mark.filterwarnings("ignore:.*TerminalReporter.writer.*")
    @pytest.mark.parametrize("colors", [(["red"]), (["green", "blue"])])
    def test_css(self, testdir, recwarn, colors):
        testdir.makepyfile("def test_pass(): pass")
        css = {}
        cssargs = []
        for color in colors:
            style = f"* {{color: {color}}}"
            path = testdir.makefile(".css", **{color: style})
            css[color] = {"style": style, "path": path}
            cssargs.extend(["--css", path])
        result, html = run(testdir, "report.html", "--self-contained-html", *cssargs)
        assert result.ret == 0
        assert len(recwarn) == 0
        for k, v in css.items():
            assert str(v["path"]) in html
            assert v["style"] in html

[nicoddemus]

Yeah unfortunately the mark is considered only for the test run, not the setup (which is where the warning is issued).

[nicoddemus]

@nicoddemus Sorry for spamming with reviewers, but this is blocking other PRs.

No worries, I appreciate the ping. 👍