Fix for including a screenshot bug on Windows (#124) #136
Conversation
|
LGTM, the failure seems unrelated though. |
|
The Node.js tests didn't run because of a problem during PhantomJS installation. This is unrelated to the proposed change. Please advise. |
|
@pinkie1378 I don't there's anything to be done in this PR, let's wait for @davehunt's input (he will be back next week it seems). |
pytest_html/plugin.py
Outdated
| # On Windows, os.path.isfile throws this exception when | ||
| # passed a b64 encoded image. | ||
| is_file = False | ||
| if is_file: |
There was a problem hiding this comment.
I'm okay with this patch, but the is_file variable name is misleading. The variable determines if the content is a URI or a path, and not specifically if it's a file. Perhaps we could use a better variable name, or change the logic to determine if the content is a base64 encoded string only falling back to creating a link when it's not.
If anyone has time to investigate that issue it would be appreciated. I had hoped to be home by now but my travel has been disrupted so I may not get time to look for a few days at best. I wouldn't hold up this patch though, if the failure is clearly unrelated. |
|
I've fixed the Travis CI failure in 764ef3c so once the requests changes have been made I'm happy to merge and release a new version. Thanks @pinkie1378 and @nicoddemus for your contributions. |
|
pytest-html 1.16.1 has been released with this fix. |
No description provided.