Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI pipeline is broken with error 'Error: IS_WINDOWS is not defined' #429

Closed
gnikonorov opened this issue Dec 18, 2020 · 6 comments
Closed
Assignees
Labels
bug This issue/PR relates to a bug. Infrastructure Changes related to project infrastructure ( CI/CD, deploy mechanism, etc. )

Comments

@gnikonorov
Copy link
Member

This seems to be related to actions/setup-python#171. It's currently affecting the master build and PRs.

FYI @BeyondEvil / @ssbarnea

@gnikonorov gnikonorov added bug This issue/PR relates to a bug. Infrastructure Changes related to project infrastructure ( CI/CD, deploy mechanism, etc. ) labels Dec 18, 2020
@gnikonorov
Copy link
Member Author

#430 rolls back to the last stable version so we can unbreak the CI pipeline

@hugovk
Copy link
Member

hugovk commented Dec 18, 2020

Will be fixed by actions/setup-python#172.

@gnikonorov
Copy link
Member Author

Thanks for the news, @hugovk! Once the fix goes to master when will a new release be made?

@gnikonorov
Copy link
Member Author

This could already be fixed as per actions/setup-python#171 (comment). I'll confirm tonight (EST)

@hugovk
Copy link
Member

hugovk commented Dec 18, 2020

Yep, looks fixed on my repo: https://github.com/hugovk/tinytext/actions/runs/428941900

@gnikonorov
Copy link
Member Author

Can confirm it's fixed on PRs and master in this repo as well. Closing this issue then since no changes are needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug. Infrastructure Changes related to project infrastructure ( CI/CD, deploy mechanism, etc. )
Projects
None yet
Development

No branches or pull requests

2 participants