image is not displaying on the report page

[p00j4]

The image link shown on the page is relative to localhost, which shows 404
http://localhost:63342/screenshots/my_screenshot.png

To Reproduce
keep a png file named my_screenshot.png in the root of project
contents of conftest.py

import os

@pytest.mark.hookwrapper
def pytest_runtest_makereport(item, call):
    outcome = yield
    report = outcome.get_result()
    pytest_html = item.config.pluginmanager.getplugin('html')
    extra = getattr(report, 'extra', [])

    main_script_dir = os.path.dirname(__file__)
    rel_path = "screenshots/my_screenshot.png" #hardcoded image file temporarily #TODO to get from driver
    image = pytest_html.extras.image(os.path.join(main_script_dir, rel_path))
    extra.append(image)
    report.extra = extra

Run with
pytest --html=report.html
Also have tried with --self-contained-html

[BeyondEvil]

What's the use-case? Why are you trying to add a screenshot manually?

[BeyondEvil]

FWIW, it works for me. Both with and without --self-contained-html

What versions are you using of python, pytest and plugins? What OS?

[p00j4]

@BeyondEvil thanks for quick response.
Use-case: Not having UI tests right now, and wanted to test the screenshot capture in the framework design phase.
Is it not supposed to work this way, does it need to be converted to base64 (tried that too but ran in other code errors on adding to extra, so chucked)

Version info my bad missed last time

Python 3.7.3
pytest               5.3.2     
pytest-check         0.3.6     
pytest-custom-report 1.0.1     
pytest-forked        1.1.3     
pytest-html          2.0.1     
pytest-metadata      1.8.0     
pytest-runner        5.2       
pytest-xdist         1.31.0    

[BeyondEvil]

@p00j4 No worries.

Like I said, I can't repro, so not sure what's going on. I'll try again with your exact environment.

But yes, assets needs to be B64 (see here), but that should be handled by pytest_html.extras.image

[ice7mayu]

Try inserting extra HTML with your image relative path embed, like this:

extra.append(pytest_html.extras.html(
     f'<div class="image"><img src="img/{rel_path}"/></div>')
)

[christiansandberg]

I can’t find any documentation on what “content” you can add. I had to look at the code to figure out it should be Base64 encoded. Also if you use relative path then the report file must be in the current working directory as the href is not adjusted based on the path to the report.

[BeyondEvil]

I can’t find any documentation on what “content” you can add. I had to look at the code to figure out it should be Base64 encoded. Also if you use relative path then the report file must be in the current working directory as the href is not adjusted based on the path to the report.

Good catch @christiansandberg !

Mind opening a separate issue for improving the docs? 🙏

[dhalperi]

Hey, I think this is a bug introduced in 2.1.0 and results from a refactoring change: 588c41b

Before, the html.img() function is run on the created asset. After, the analogous raw(base_extra_string.format is not run on the created asset.

For more info, see pytest-dev/pytest-selenium#237