fix up py.error importability #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
force-pushed
the
fix-py-error
branch
from
4c437d2 to
195595c
Compare
nicoddemus
reviewed
Feb 26, 2018
tox.ini
Outdated
| @@ -8,6 +8,7 @@ commands= | |||
|
|
|||
| py.test --confcutdir=.. -rfsxX --junitxml={envlogdir}/junit-{envname}.xml [] | |||
| deps= | |||
| attrs | |||
There was a problem hiding this comment.
Please fix the indentation here
nicoddemus
requested changes
Feb 26, 2018
There was a problem hiding this comment.
Please add a test as well @RonnyPfannschmidt, we don't want to introduce a regression by accident in the future. 👍
fix indent in tox.ini fix and extend tests for error
|
man, some mondays, thanks for tackling my slack |
|
Heh it happens to all of us! 😁 |
|
Also I just realized that |
|
ouch, thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.