Prove that PluginManger.register() ignores non-routines
#97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodboy
requested review from
RonnyPfannschmidt,
The-Compiler and
nicoddemus
goodboy
force-pushed
the
test_reject_non_routine_hookimpls
branch
from
3fadbbf to
5f52422
Compare
nicoddemus
reviewed
Nov 12, 2017
| when registering a module which imports it. | ||
| """ | ||
| pm._implprefix = 'example' | ||
| conftest = types.ModuleType("conftest") |
Member
There was a problem hiding this comment.
For completeness, I would add an example_ function to one of the modules and ensure that it is collected.
Contributor
Author
There was a problem hiding this comment.
Done. Heh, and found a bug from the _Multicall refactor.. shocker we've got no tests for the undecorated hook collection stuff.
goodboy
force-pushed
the
test_reject_non_routine_hookimpls
branch
from
5f52422 to
3fa0ab4
Compare
Contributor
Author
|
Hopefully the use of |
goodboy
force-pushed
the
test_reject_non_routine_hookimpls
branch
from
3fa0ab4 to
196229b
Compare
This proves that pytest-dev#91 is a problem in `pytest` and not `pluggy`. Thanks to @RonnyPfannschmidt for the fix about a year ago ;)
goodboy
force-pushed
the
test_reject_non_routine_hookimpls
branch
from
196229b to
8ce9161
Compare
This was referenced Nov 24, 2017
This was referenced Dec 8, 2017
This was referenced Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proves that #91 is a problem in
pytestand notpluggy.Thanks to @RonnyPfannschmidt for the fix about a year ago ;)