-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to https://github.com/hynek/build-and-inspect-python-package/ #524
base: main
Are you sure you want to change the base?
Conversation
RonnyPfannschmidt
commented
Aug 17, 2024
- migrate to pyproject.toml tooling
- migrate to https://github.com/hynek/build-and-inspect-python-package/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Left a few suggestions.
.github/workflows/main.yml
Outdated
run: python -m build --sdist --wheel --outdir dist/ | ||
|
||
name: Packages | ||
path: dist | ||
- name: Publish package | ||
uses: pypa/gh-action-pypi-publish@v1.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While at it let's try the new attestations support:
uses: pypa/gh-action-pypi-publish@v1.9.0 | |
uses: pypa/gh-action-pypi-publish@v1.10.1 | |
with: | |
attestations: true |
pyproject.toml
Outdated
[project] | ||
name = "pluggy" | ||
license = {text = "MIT"} | ||
authors = [{name = "Holger Krekel", email = "holger@merlinux.eu"}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While at it should we update this? Not sure to what exactly though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm up for being on the hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm up for being on the hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking more if it is appropriate to add pytest core team <core@pytest.org>
or something like that.
pyproject.toml
Outdated
name = "pluggy" | ||
license = {text = "MIT"} | ||
authors = [{name = "Holger Krekel", email = "holger@merlinux.eu"}] | ||
classifiers = ["Development Status :: 6 - Mature", "Intended Audience :: Developers", "License :: OSI Approved :: MIT License", "Operating System :: POSIX", "Operating System :: Microsoft :: Windows", "Operating System :: MacOS :: MacOS X", "Topic :: Software Development :: Testing", "Topic :: Software Development :: Libraries", "Topic :: Utilities", "Programming Language :: Python :: Implementation :: CPython", "Programming Language :: Python :: Implementation :: PyPy", "Programming Language :: Python :: 3", "Programming Language :: Python :: 3 :: Only", "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
classifiers = ["Development Status :: 6 - Mature", "Intended Audience :: Developers", "License :: OSI Approved :: MIT License", "Operating System :: POSIX", "Operating System :: Microsoft :: Windows", "Operating System :: MacOS :: MacOS X", "Topic :: Software Development :: Testing", "Topic :: Software Development :: Libraries", "Topic :: Utilities", "Programming Language :: Python :: Implementation :: CPython", "Programming Language :: Python :: Implementation :: PyPy", "Programming Language :: Python :: 3", "Programming Language :: Python :: 3 :: Only", "Programming Language :: Python :: 3.8", "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11"] | |
classifiers = [ | |
"Development Status :: 6 - Mature", | |
"Intended Audience :: Developers", | |
"License :: OSI Approved :: MIT License", | |
"Operating System :: POSIX", | |
"Operating System :: Microsoft :: Windows", | |
"Operating System :: MacOS :: MacOS X", | |
"Topic :: Software Development :: Testing", | |
"Topic :: Software Development :: Libraries", | |
"Topic :: Utilities", "Programming Language :: Python :: Implementation :: CPython", | |
"Programming Language :: Python :: Implementation :: PyPy", "Programming Language :: Python :: 3", | |
"Programming Language :: Python :: 3 :: Only", | |
"Programming Language :: Python :: 3.8", | |
"Programming Language :: Python :: 3.9", | |
"Programming Language :: Python :: 3.10", | |
"Programming Language :: Python :: 3.11", | |
"Programming Language :: Python :: 3.12", | |
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pyproject.toml migration LGTM, I'm not qualified to review the rest. Maybe adding pyproject.fmt first in pre-commit would be great.
4816b4b
to
0723def
Compare