-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
References overhaul #236
References overhaul #236
Conversation
…here possible Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 14 14
Lines 1651 1651
Branches 115 115
=======================================
Hits 1534 1534
Misses 101 101
Partials 16 16
Continue to review full report at Codecov.
|
@hoefling that's my old account. I guess just link to my new one? Other then that this looks mostly good to me though I'll do another run through after others have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
Signed-off-by: Oleg Höfling <oleg.hoefling@gmail.com>
@goodboy Oh, didn't know that - easy fix, then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hoefling wow this looks great!
I actually learned a few more fancy things about sphinx
reading through this.
Really nice to see the intersphinx_mapping
stuff put to work too - it definitely minimizes on the number of redefined links!
@RonnyPfannschmidt @nicoddemus this get's a stamp from me. If you two don't have the time to look through this I think it's ready to land. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just awesome, thanks
@goodboy thanks, glad it was helpful. Sphinx offers more fancy stuff that could be used - for example, I noticed definitions throughout the docs that could be collected under a |
Closing #186.
Running
linkcheck
now yields only one broken link to tgoodlet user account, rest are fixed. Also replaced hardcoded links withintersphinx
refs where possible. Extended apidoc to a minimal amount of private classes/methods, enough just to fix the existing refs.The second commit adds some crossrefs between the docstrings and some minor formatting improvements. This one is more a suggestion and I wouldn't mind throwing it away - check whether it really adds a significant amount of readability.