Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest won't run root conftest.py's pytest_configure in special circumstances #438

Closed
Redoubts opened this issue Sep 1, 2023 · 2 comments · Fixed by #473
Closed

pytest won't run root conftest.py's pytest_configure in special circumstances #438

Redoubts opened this issue Sep 1, 2023 · 2 comments · Fixed by #473

Comments

@Redoubts
Copy link

Redoubts commented Sep 1, 2023

Wanted to cross post pytest-dev/pytest#11365 here, in case it might be on the pluggy side:

Consider the following project: https://github.com/Redoubts/_pytest_bug_report

There's a root level conftest.py, and 3 plugins (two loaded in the conftest, and a third loaded by plugin 2). All define a pytest_configure in some way.

with platform darwin -- Python 3.11.4, pytest-7.4.0, pluggy-1.0.0, we see

% pytest test1.py
mypackage.plugin2 Configured
mypackage.plugin3 Configured
conftest Configured
mypackage.plugin Configured

Which is somewhat expected, each pytest_configure gets called.

If you update pluggy to 1.2+, you see

% pytest test1.py           
mypackage.plugin2 Configured
mypackage.plugin3 Configured
mypackage.plugin Configured
mypackage.plugin3 Configured
============================================================================================ test session starts =============================================================================================
platform darwin -- Python 3.11.4, pytest-7.4.0, pluggy-1.2.0
...

Where the third plugin's pytest_configure is called twice, but the root pytest_configure is never called.

I think this is more specifically due to mypackage/plugin3.py's @pytest.hookimpl wrapper. Maybe it's ill advised to do that, but I found this bizarre scenario when testing package updates in a much larger codebase.

@bluetech
Copy link
Member

Thanks for the bug report and reproduction.

This regressed with commit 63b7e90 - pluggy 1.1.0.

Problem

In this commit I made an optimization such that the list of hook implementations of a hook (_hookimpls) is no longer copied on every call to the hook. But I neglected to think about the case when _hookimpls is modified by calling the hook itself. This is what happens in your reproduction:

  • pytest calls the pytest_configure hook
  • plugin2.pytest_configure calls pm.register(Plugin3())
  • Plugin3 implements pytest_configure

Why is plugin3 called twice? First time, because pytest_configure is an historic hook and so it's called by the register().
Second time, because its registration modifies _hookimpls while it is being iterated and it ends up being included in the call.

Why is the conftest getting skipped? Because it's something that can happen when invalidating an iterator. Example:

l = [0, 1, 2]
for x in reversed(l):
    print(x)
    if x == 1:
        l.insert(0, -1)

This prints 2, 1, -1 and 0 is skipped.

BTW, if I modify pluggy to avoid the reverse, then the conftest isn't skipped. But this is incidental, it could have just as well caused an infinite loop (try removing reversed from the snippet above).

Possible solutions

First solution is to bring back the copy.

Second solution is to disallow doing this in one way or another. However pytest explicitly documents this patten so this may be out of the question.

Third solution is to somehow make this work without the copy.

bluetech added a commit to bluetech/pluggy that referenced this issue Jan 20, 2024
when the other plugins implement the same hook itself.

Fix pytest-dev#438.
Regressed in 63b7e90 - pluggy 1.1.0.

Went with the simple solution described in the issue for now, basically
undoing most of the rationale for 63b7e90 (though I
think it's still better to have a single `_hookimpls` list).
@Redoubts
Copy link
Author

ty for addressing!

ErikBavenstrand added a commit to klarna-incubator/mleko that referenced this issue Jan 25, 2024
Bumps [pluggy](https://github.com/pytest-dev/pluggy) from 1.3.0 to
1.4.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pytest-dev/pluggy/blob/main/CHANGELOG.rst">pluggy's
changelog</a>.</em></p>
<blockquote>
<h1>pluggy 1.4.0 (2024-01-24)</h1>
<h2>Features</h2>
<ul>
<li>
<p><code>[#463](pytest-dev/pluggy#463)
&lt;https://github.com/pytest-dev/pluggy/issues/463&gt;</code>_: A
warning :class:<code>~pluggy.PluggyTeardownRaisedWarning</code> is now
issued when an old-style hookwrapper raises an exception during
teardown.
See the warning documentation for more details.</p>
</li>
<li>
<p><code>[#471](pytest-dev/pluggy#471)
&lt;https://github.com/pytest-dev/pluggy/issues/471&gt;</code>_: Add
:func:<code>PluginManager.unblock
&lt;pluggy.PluginManager.unblock&gt;</code> method to unblock a plugin
by plugin name.</p>
</li>
</ul>
<h2>Bug Fixes</h2>
<ul>
<li>
<p><code>[#441](pytest-dev/pluggy#441)
&lt;https://github.com/pytest-dev/pluggy/issues/441&gt;</code>_: Fix
:func:<code>~pluggy.HookCaller.call_extra()</code> extra methods getting
ordered before everything else in some circumstances. Regressed in
pluggy 1.1.0.</p>
</li>
<li>
<p><code>[#438](pytest-dev/pluggy#438)
&lt;https://github.com/pytest-dev/pluggy/issues/438&gt;</code>_: Fix
plugins registering other plugins in a hook when the other plugins
implement the same hook itself. Regressed in pluggy 1.1.0.</p>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/2efd28ef5dcd8b7ad44a41777ce640debbbf9c39"><code>2efd28e</code></a>
Preparing release 1.4.0</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/ebeb2f2e7865369e48d953c3dff1789d448f104e"><code>ebeb2f2</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/471">#471</a>
from bluetech/unblock</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/3a28b4d7a6d07ff3b3263ac2909be804323f578c"><code>3a28b4d</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/464">#464</a>
from bluetech/hookwrapper-teardown-warning</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/4331b7a164b6f0e79d2e64c8144e9bcb077f3a16"><code>4331b7a</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/473">#473</a>
from bluetech/iterator-invalidation</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/7aef3e608fddc57648daffaec23432e6893f26ff"><code>7aef3e6</code></a>
hooks: fix plugins registering other plugins in a hook</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/cc36605090dfa090777b3d69ca91132ad852c6f2"><code>cc36605</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/472">#472</a>
from bluetech/call-extra-ordering-fix</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/443fee6d7a30ca694aa2eec77bde4aea9356efa0"><code>443fee6</code></a>
hooks: fix <code>call_extra</code> extra methods getting ordered before
everything else</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/4577b459a9043ba283e0d7a39beeddd627cc54a0"><code>4577b45</code></a>
hooks: add comment describing <code>_hookimpls</code>'s
format/invariants.</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/13b3661080cd3f6dcae1dedbceac6814b740c6dc"><code>13b3661</code></a>
Add <code>PluginManager.unblock</code> method to unblock a name</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/4b5b2d4ede425742d99ebb6539c42517a4401dc0"><code>4b5b2d4</code></a>
CHANGELOG: fix errors in 1.0.0 entry</li>
<li>Additional commits viewable in <a
href="https://github.com/pytest-dev/pluggy/compare/1.3.0...1.4.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pluggy&package-manager=pip&previous-version=1.3.0&new-version=1.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>
github-actions bot added a commit to MaRDI4NFDI/open-interfaces that referenced this issue Jan 29, 2024
Bumps [pluggy](https://github.com/pytest-dev/pluggy) from 1.3.0 to
1.4.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pytest-dev/pluggy/blob/main/CHANGELOG.rst">pluggy's
changelog</a>.</em></p>
<blockquote>
<h1>pluggy 1.4.0 (2024-01-24)</h1>
<h2>Features</h2>
<ul>
<li>
<p><code>[#463](pytest-dev/pluggy#463)
&lt;https://github.com/pytest-dev/pluggy/issues/463&gt;</code>_: A
warning :class:<code>~pluggy.PluggyTeardownRaisedWarning</code> is now
issued when an old-style hookwrapper raises an exception during
teardown.
See the warning documentation for more details.</p>
</li>
<li>
<p><code>[#471](pytest-dev/pluggy#471)
&lt;https://github.com/pytest-dev/pluggy/issues/471&gt;</code>_: Add
:func:<code>PluginManager.unblock
&lt;pluggy.PluginManager.unblock&gt;</code> method to unblock a plugin
by plugin name.</p>
</li>
</ul>
<h2>Bug Fixes</h2>
<ul>
<li>
<p><code>[#441](pytest-dev/pluggy#441)
&lt;https://github.com/pytest-dev/pluggy/issues/441&gt;</code>_: Fix
:func:<code>~pluggy.HookCaller.call_extra()</code> extra methods getting
ordered before everything else in some circumstances. Regressed in
pluggy 1.1.0.</p>
</li>
<li>
<p><code>[#438](pytest-dev/pluggy#438)
&lt;https://github.com/pytest-dev/pluggy/issues/438&gt;</code>_: Fix
plugins registering other plugins in a hook when the other plugins
implement the same hook itself. Regressed in pluggy 1.1.0.</p>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/2efd28ef5dcd8b7ad44a41777ce640debbbf9c39"><code>2efd28e</code></a>
Preparing release 1.4.0</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/ebeb2f2e7865369e48d953c3dff1789d448f104e"><code>ebeb2f2</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/471">#471</a>
from bluetech/unblock</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/3a28b4d7a6d07ff3b3263ac2909be804323f578c"><code>3a28b4d</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/464">#464</a>
from bluetech/hookwrapper-teardown-warning</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/4331b7a164b6f0e79d2e64c8144e9bcb077f3a16"><code>4331b7a</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/473">#473</a>
from bluetech/iterator-invalidation</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/7aef3e608fddc57648daffaec23432e6893f26ff"><code>7aef3e6</code></a>
hooks: fix plugins registering other plugins in a hook</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/cc36605090dfa090777b3d69ca91132ad852c6f2"><code>cc36605</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/472">#472</a>
from bluetech/call-extra-ordering-fix</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/443fee6d7a30ca694aa2eec77bde4aea9356efa0"><code>443fee6</code></a>
hooks: fix <code>call_extra</code> extra methods getting ordered before
everything else</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/4577b459a9043ba283e0d7a39beeddd627cc54a0"><code>4577b45</code></a>
hooks: add comment describing <code>_hookimpls</code>'s
format/invariants.</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/13b3661080cd3f6dcae1dedbceac6814b740c6dc"><code>13b3661</code></a>
Add <code>PluginManager.unblock</code> method to unblock a name</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/4b5b2d4ede425742d99ebb6539c42517a4401dc0"><code>4b5b2d4</code></a>
CHANGELOG: fix errors in 1.0.0 entry</li>
<li>Additional commits viewable in <a
href="https://github.com/pytest-dev/pluggy/compare/1.3.0...1.4.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pluggy&package-manager=pip&previous-version=1.3.0&new-version=1.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>
Teqed added a commit to Teqed/FediFetcher that referenced this issue Jan 31, 2024
Bumps [pluggy](https://github.com/pytest-dev/pluggy) from 1.3.0 to
1.4.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pytest-dev/pluggy/blob/main/CHANGELOG.rst">pluggy's
changelog</a>.</em></p>
<blockquote>
<h1>pluggy 1.4.0 (2024-01-24)</h1>
<h2>Features</h2>
<ul>
<li>
<p><code>[#463](pytest-dev/pluggy#463)
&lt;https://github.com/pytest-dev/pluggy/issues/463&gt;</code>_: A
warning :class:<code>~pluggy.PluggyTeardownRaisedWarning</code> is now
issued when an old-style hookwrapper raises an exception during
teardown.
See the warning documentation for more details.</p>
</li>
<li>
<p><code>[#471](pytest-dev/pluggy#471)
&lt;https://github.com/pytest-dev/pluggy/issues/471&gt;</code>_: Add
:func:<code>PluginManager.unblock
&lt;pluggy.PluginManager.unblock&gt;</code> method to unblock a plugin
by plugin name.</p>
</li>
</ul>
<h2>Bug Fixes</h2>
<ul>
<li>
<p><code>[#441](pytest-dev/pluggy#441)
&lt;https://github.com/pytest-dev/pluggy/issues/441&gt;</code>_: Fix
:func:<code>~pluggy.HookCaller.call_extra()</code> extra methods getting
ordered before everything else in some circumstances. Regressed in
pluggy 1.1.0.</p>
</li>
<li>
<p><code>[#438](pytest-dev/pluggy#438)
&lt;https://github.com/pytest-dev/pluggy/issues/438&gt;</code>_: Fix
plugins registering other plugins in a hook when the other plugins
implement the same hook itself. Regressed in pluggy 1.1.0.</p>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/2efd28ef5dcd8b7ad44a41777ce640debbbf9c39"><code>2efd28e</code></a>
Preparing release 1.4.0</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/ebeb2f2e7865369e48d953c3dff1789d448f104e"><code>ebeb2f2</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/471">#471</a>
from bluetech/unblock</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/3a28b4d7a6d07ff3b3263ac2909be804323f578c"><code>3a28b4d</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/464">#464</a>
from bluetech/hookwrapper-teardown-warning</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/4331b7a164b6f0e79d2e64c8144e9bcb077f3a16"><code>4331b7a</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/473">#473</a>
from bluetech/iterator-invalidation</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/7aef3e608fddc57648daffaec23432e6893f26ff"><code>7aef3e6</code></a>
hooks: fix plugins registering other plugins in a hook</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/cc36605090dfa090777b3d69ca91132ad852c6f2"><code>cc36605</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/472">#472</a>
from bluetech/call-extra-ordering-fix</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/443fee6d7a30ca694aa2eec77bde4aea9356efa0"><code>443fee6</code></a>
hooks: fix <code>call_extra</code> extra methods getting ordered before
everything else</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/4577b459a9043ba283e0d7a39beeddd627cc54a0"><code>4577b45</code></a>
hooks: add comment describing <code>_hookimpls</code>'s
format/invariants.</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/13b3661080cd3f6dcae1dedbceac6814b740c6dc"><code>13b3661</code></a>
Add <code>PluginManager.unblock</code> method to unblock a name</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/4b5b2d4ede425742d99ebb6539c42517a4401dc0"><code>4b5b2d4</code></a>
CHANGELOG: fix errors in 1.0.0 entry</li>
<li>Additional commits viewable in <a
href="https://github.com/pytest-dev/pluggy/compare/1.3.0...1.4.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pluggy&package-manager=pip&previous-version=1.3.0&new-version=1.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>
rababerladuseladim pushed a commit to robert-koch-institut/mex-backend that referenced this issue Feb 2, 2024
Bumps [pluggy](https://github.com/pytest-dev/pluggy) from 1.3.0 to
1.4.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pytest-dev/pluggy/blob/main/CHANGELOG.rst">pluggy's
changelog</a>.</em></p>
<blockquote>
<h1>pluggy 1.4.0 (2024-01-24)</h1>
<h2>Features</h2>
<ul>
<li>
<p><code>[#463](pytest-dev/pluggy#463)
&lt;https://github.com/pytest-dev/pluggy/issues/463&gt;</code>_: A
warning :class:<code>~pluggy.PluggyTeardownRaisedWarning</code> is now
issued when an old-style hookwrapper raises an exception during
teardown.
See the warning documentation for more details.</p>
</li>
<li>
<p><code>[#471](pytest-dev/pluggy#471)
&lt;https://github.com/pytest-dev/pluggy/issues/471&gt;</code>_: Add
:func:<code>PluginManager.unblock
&lt;pluggy.PluginManager.unblock&gt;</code> method to unblock a plugin
by plugin name.</p>
</li>
</ul>
<h2>Bug Fixes</h2>
<ul>
<li>
<p><code>[#441](pytest-dev/pluggy#441)
&lt;https://github.com/pytest-dev/pluggy/issues/441&gt;</code>_: Fix
:func:<code>~pluggy.HookCaller.call_extra()</code> extra methods getting
ordered before everything else in some circumstances. Regressed in
pluggy 1.1.0.</p>
</li>
<li>
<p><code>[#438](pytest-dev/pluggy#438)
&lt;https://github.com/pytest-dev/pluggy/issues/438&gt;</code>_: Fix
plugins registering other plugins in a hook when the other plugins
implement the same hook itself. Regressed in pluggy 1.1.0.</p>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/2efd28ef5dcd8b7ad44a41777ce640debbbf9c39"><code>2efd28e</code></a>
Preparing release 1.4.0</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/ebeb2f2e7865369e48d953c3dff1789d448f104e"><code>ebeb2f2</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/471">#471</a>
from bluetech/unblock</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/3a28b4d7a6d07ff3b3263ac2909be804323f578c"><code>3a28b4d</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/464">#464</a>
from bluetech/hookwrapper-teardown-warning</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/4331b7a164b6f0e79d2e64c8144e9bcb077f3a16"><code>4331b7a</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/473">#473</a>
from bluetech/iterator-invalidation</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/7aef3e608fddc57648daffaec23432e6893f26ff"><code>7aef3e6</code></a>
hooks: fix plugins registering other plugins in a hook</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/cc36605090dfa090777b3d69ca91132ad852c6f2"><code>cc36605</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/472">#472</a>
from bluetech/call-extra-ordering-fix</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/443fee6d7a30ca694aa2eec77bde4aea9356efa0"><code>443fee6</code></a>
hooks: fix <code>call_extra</code> extra methods getting ordered before
everything else</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/4577b459a9043ba283e0d7a39beeddd627cc54a0"><code>4577b45</code></a>
hooks: add comment describing <code>_hookimpls</code>'s
format/invariants.</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/13b3661080cd3f6dcae1dedbceac6814b740c6dc"><code>13b3661</code></a>
Add <code>PluginManager.unblock</code> method to unblock a name</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/4b5b2d4ede425742d99ebb6539c42517a4401dc0"><code>4b5b2d4</code></a>
CHANGELOG: fix errors in 1.0.0 entry</li>
<li>Additional commits viewable in <a
href="https://github.com/pytest-dev/pluggy/compare/1.3.0...1.4.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pluggy&package-manager=pip&previous-version=1.3.0&new-version=1.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
evroon pushed a commit to evroon/bracket that referenced this issue Feb 15, 2024
Updates the requirements on
[pluggy](https://github.com/pytest-dev/pluggy) to permit the latest
version.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pytest-dev/pluggy/blob/main/CHANGELOG.rst">pluggy's
changelog</a>.</em></p>
<blockquote>
<h1>pluggy 1.4.0 (2024-01-24)</h1>
<h2>Features</h2>
<ul>
<li>
<p><code>[#463](pytest-dev/pluggy#463)
&lt;https://github.com/pytest-dev/pluggy/issues/463&gt;</code>_: A
warning :class:<code>~pluggy.PluggyTeardownRaisedWarning</code> is now
issued when an old-style hookwrapper raises an exception during
teardown.
See the warning documentation for more details.</p>
</li>
<li>
<p><code>[#471](pytest-dev/pluggy#471)
&lt;https://github.com/pytest-dev/pluggy/issues/471&gt;</code>_: Add
:func:<code>PluginManager.unblock
&lt;pluggy.PluginManager.unblock&gt;</code> method to unblock a plugin
by plugin name.</p>
</li>
</ul>
<h2>Bug Fixes</h2>
<ul>
<li>
<p><code>[#441](pytest-dev/pluggy#441)
&lt;https://github.com/pytest-dev/pluggy/issues/441&gt;</code>_: Fix
:func:<code>~pluggy.HookCaller.call_extra()</code> extra methods getting
ordered before everything else in some circumstances. Regressed in
pluggy 1.1.0.</p>
</li>
<li>
<p><code>[#438](pytest-dev/pluggy#438)
&lt;https://github.com/pytest-dev/pluggy/issues/438&gt;</code>_: Fix
plugins registering other plugins in a hook when the other plugins
implement the same hook itself. Regressed in pluggy 1.1.0.</p>
</li>
</ul>
<h1>pluggy 1.3.0 (2023-08-26)</h1>
<h2>Deprecations and Removals</h2>
<ul>
<li><code>[#426](pytest-dev/pluggy#426)
&lt;https://github.com/pytest-dev/pluggy/issues/426&gt;</code>_: Python
3.7 is no longer supported.</li>
</ul>
<h2>Features</h2>
<ul>
<li>
<p><code>[#428](pytest-dev/pluggy#428)
&lt;https://github.com/pytest-dev/pluggy/issues/428&gt;</code>_: Pluggy
now exposes its typings to static type checkers.</p>
<p>As part of this, the following changes are made:</p>
<ul>
<li>Renamed <code>_Result</code> to <code>Result</code>, and exported as
:class:<code>pluggy.Result</code>.</li>
<li>Renamed <code>_HookRelay</code> to <code>HookRelay</code>, and
exported as :class:<code>pluggy.HookRelay</code>.</li>
<li>Renamed <code>_HookCaller</code> to <code>HookCaller</code>, and
exported as :class:<code>pluggy.HookCaller</code>.</li>
<li>Exported <code>HookImpl</code> as
:class:<code>pluggy.HookImpl</code>.</li>
<li>Renamed <code>_HookImplOpts</code> to <code>HookimplOpts</code>, and
exported as :class:<code>pluggy.HookimplOpts</code>.</li>
<li>Renamed <code>_HookSpecOpts</code> to <code>HookspecOpts</code>, and
exported as :class:<code>pluggy.HookspecOpts</code>.</li>
<li>Some fields and classes are marked <code>Final</code> and
<code>@Final</code>.</li>
<li>The :ref:<code>api-reference</code> is updated to clearly delineate
pluggy's public API.</li>
</ul>
<p>Compatibility aliases are put in place for the renamed types.
We do not plan to remove the aliases, but we strongly recommend to only
import from <code>pluggy.*</code> to ensure future compatibility.</p>
<p>Please note that pluggy is currently unable to provide strong typing
for hook calls, e.g. <code>pm.hook.my_hook(...)</code>,
nor to statically check that a hook implementation matches the hook
specification's type.</p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/2efd28ef5dcd8b7ad44a41777ce640debbbf9c39"><code>2efd28e</code></a>
Preparing release 1.4.0</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/ebeb2f2e7865369e48d953c3dff1789d448f104e"><code>ebeb2f2</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/471">#471</a>
from bluetech/unblock</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/3a28b4d7a6d07ff3b3263ac2909be804323f578c"><code>3a28b4d</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/464">#464</a>
from bluetech/hookwrapper-teardown-warning</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/4331b7a164b6f0e79d2e64c8144e9bcb077f3a16"><code>4331b7a</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/473">#473</a>
from bluetech/iterator-invalidation</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/7aef3e608fddc57648daffaec23432e6893f26ff"><code>7aef3e6</code></a>
hooks: fix plugins registering other plugins in a hook</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/cc36605090dfa090777b3d69ca91132ad852c6f2"><code>cc36605</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/472">#472</a>
from bluetech/call-extra-ordering-fix</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/443fee6d7a30ca694aa2eec77bde4aea9356efa0"><code>443fee6</code></a>
hooks: fix <code>call_extra</code> extra methods getting ordered before
everything else</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/4577b459a9043ba283e0d7a39beeddd627cc54a0"><code>4577b45</code></a>
hooks: add comment describing <code>_hookimpls</code>'s
format/invariants.</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/13b3661080cd3f6dcae1dedbceac6814b740c6dc"><code>13b3661</code></a>
Add <code>PluginManager.unblock</code> method to unblock a name</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/4b5b2d4ede425742d99ebb6539c42517a4401dc0"><code>4b5b2d4</code></a>
CHANGELOG: fix errors in 1.0.0 entry</li>
<li>Additional commits viewable in <a
href="https://github.com/pytest-dev/pluggy/compare/0.3.0...1.4.0">compare
view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
evroon pushed a commit to evroon/bracket that referenced this issue Apr 22, 2024
Updates the requirements on
[pluggy](https://github.com/pytest-dev/pluggy) to permit the latest
version.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pytest-dev/pluggy/blob/main/CHANGELOG.rst">pluggy's
changelog</a>.</em></p>
<blockquote>
<h1>pluggy 1.5.0 (2024-04-19)</h1>
<h2>Features</h2>
<ul>
<li>
<p><code>[#178](pytest-dev/pluggy#178)
&lt;https://github.com/pytest-dev/pluggy/issues/178&gt;</code>_: Add
support for deprecating specific hook parameters, or more generally, for
issuing a warning whenever a hook implementation requests certain
parameters.</p>
<p>See :ref:<code>warn_on_impl</code> for details.</p>
</li>
</ul>
<h2>Bug Fixes</h2>
<ul>
<li><code>[#481](pytest-dev/pluggy#481)
&lt;https://github.com/pytest-dev/pluggy/issues/481&gt;</code>_:
<code>PluginManager.get_plugins()</code> no longer returns
<code>None</code> for blocked plugins.</li>
</ul>
<h1>pluggy 1.4.0 (2024-01-24)</h1>
<h2>Features</h2>
<ul>
<li>
<p><code>[#463](pytest-dev/pluggy#463)
&lt;https://github.com/pytest-dev/pluggy/issues/463&gt;</code>_: A
warning :class:<code>~pluggy.PluggyTeardownRaisedWarning</code> is now
issued when an old-style hookwrapper raises an exception during
teardown.
See the warning documentation for more details.</p>
</li>
<li>
<p><code>[#471](pytest-dev/pluggy#471)
&lt;https://github.com/pytest-dev/pluggy/issues/471&gt;</code>_: Add
:func:<code>PluginManager.unblock
&lt;pluggy.PluginManager.unblock&gt;</code> method to unblock a plugin
by plugin name.</p>
</li>
</ul>
<h2>Bug Fixes</h2>
<ul>
<li>
<p><code>[#441](pytest-dev/pluggy#441)
&lt;https://github.com/pytest-dev/pluggy/issues/441&gt;</code>_: Fix
:func:<code>~pluggy.HookCaller.call_extra()</code> extra methods getting
ordered before everything else in some circumstances. Regressed in
pluggy 1.1.0.</p>
</li>
<li>
<p><code>[#438](pytest-dev/pluggy#438)
&lt;https://github.com/pytest-dev/pluggy/issues/438&gt;</code>_: Fix
plugins registering other plugins in a hook when the other plugins
implement the same hook itself. Regressed in pluggy 1.1.0.</p>
</li>
</ul>
<h1>pluggy 1.3.0 (2023-08-26)</h1>
<h2>Deprecations and Removals</h2>
<ul>
<li><code>[#426](pytest-dev/pluggy#426)
&lt;https://github.com/pytest-dev/pluggy/issues/426&gt;</code>_: Python
3.7 is no longer supported.</li>
</ul>
<h2>Features</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/f8aa4a009716a7994f2f6c1947d9fa69feccbdd5"><code>f8aa4a0</code></a>
Preparing release 1.5.0</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/b4a8c92fb15dc05376ddb9b48e601be00ee3ee1b"><code>b4a8c92</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/495">#495</a>
from bluetech/warn-on-impl-args</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/6f6ea680ca5a1f73dca356eb23c0dd6bd5f7190e"><code>6f6ea68</code></a>
Add support deprecating hook parameters</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/91f88d28e30c12612d671100b7a60dfbf4990446"><code>91f88d2</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/496">#496</a>
from bluetech/codecov-action</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/89ce829b44274569de83173867ce29828b620fe8"><code>89ce829</code></a>
ci: replace upload-coverage script with codecov github action</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/29f104d21f06f0bf1415a8e872657bc10a768954"><code>29f104d</code></a>
Lift pluggy (<a
href="https://redirect.github.com/pytest-dev/pluggy/issues/493">#493</a>)</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/c2b36b44af5c2530813e18553b54158535d4820a"><code>c2b36b4</code></a>
Merge pull request <a
href="https://redirect.github.com/pytest-dev/pluggy/issues/491">#491</a>
from pytest-dev/pre-commit-ci-update-config</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/2b533c9d9f7421c9353aa32da967733bfe4c1c85"><code>2b533c9</code></a>
[pre-commit.ci] pre-commit autoupdate</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/04d1bcdbc751a90ff79b72caf85dc96e1664ae45"><code>04d1bcd</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://redirect.github.com/pytest-dev/pluggy/issues/490">#490</a>)</li>
<li><a
href="https://github.com/pytest-dev/pluggy/commit/f74e94b17d986c18e9039af87ecded9c9546ac32"><code>f74e94b</code></a>
[pre-commit.ci] pre-commit autoupdate (<a
href="https://redirect.github.com/pytest-dev/pluggy/issues/489">#489</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/pytest-dev/pluggy/compare/0.3.0...1.5.0">compare
view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants