Release 1.0?

[nicoddemus]

Hi,

As has been discussed before, is it time to start discussing about the 1.0 release? It has been in use in production in pytest, tox and devpi for some time after all.

• Do we have any major changes that are backward incompatible?
• What to do about our scheduled deprecations?

Milestone 1.0

https://github.com/pytest-dev/pluggy/milestone/1

[goodboy]

@nicoddemus sorry must have missed this. Yes I guess we should start working seriously towards this.

I was kind of hoping for at least the following features to be brought in before 1.0:

• support the creation fo an actual plugin dependency tree and use its root for consideration/order #51
• Have a unified way of showing info about installed plugins #87

This would lay a clean-ish slate for moving onto bigger and better ideas.
It's my bad for not being more on top of this; I've been somewhat distracted with other projects recently.

I would love to see the deprecation list finished up as well yes!
I'd be interested in setting some milestones so that we can start pushing towards this.

[RonnyPfannschmidt]

#51 is too big and complicated to get right in any kind of rush
#87 is "just a feature" and needs experimentation in any case to get the api level right (see the discussion there)

we need to reiterate introducing/removing arguments for invocations over time - i'd like to have @hpk42 as part of that discussion

[hpk42]

I haven't tracked pluggy development lately. FWIW a 1.0 sounds fine with me, it's indeed stable enough and there can always be a 1.1 and 2.0.

…

On Mon, Apr 30, 2018 at 06:47 -0700, Ronny Pfannschmidt wrote: #51 is too big and complicated to get right in any kind of rush #87 is "just a feature" and needs experimentation in any case to get the api level right (see the discussion there) we need to reiterate introducing/removing arguments for invocations over time - i'd like to have @hpk42 as part of that discussion -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #140 (comment)

[nicoddemus]

I agree with @hpk42, IMO we only need to hold a 1.0 release if we have plans for backward incompatible changes for the near feature or if there are things we should start deprecating now, otherwise new features can come in the next minor releases.

The main thing for me is that we have been using pluggy in production for years, so it is definitely production-ready.

[RonnyPfannschmidt]

i agree - thanks everyone for the input

[goodboy]

So should we move forward with the deprecation list then now or no?
I think it'd be good to get some of the cruft flushed out of the code base if at all possible - less is more some say :)

[nicoddemus]

By deprecation list you mean deprecation ?

• Deprecate (and eventually remove) implprefix support #116 Deprecate (and remove) implprefix support - pytest can't really live without this, so as we discussed we should implement it into PytestPluginManager and remove it from pluggy.
• Remove __multicall__ support #59 Remove multicall support - This has been deprecated for a few years now and I think there are very few (if any) pytest plugins which still use this. I think it is fair to remove it altogether.
• Change call_historic callback kwarg name #120 Change call_historic callback kwarg name: not sure what's the real impact here from the POV of pytest.

[goodboy]

@nicoddemus @RonnyPfannschmidt so sorry I've let this slide.

So what's the consensus?
Stick with just the deprecation list for now?

[RonnyPfannschmidt]

yeah

[nicoddemus]

Before deprecating the impl-prefix support, we should port it over to pytest; every pytest plugin uses it, so it wouldn't be helpful to release a pluggy version which issues warnings for its usage.

[bluetech]

Since Python 2 is now officially no longer supported, perhaps pluggy 1.0 can be Python3-only?

pytest is 3-only, so it's not a problem for it. Not sure about other pluggy users, but Python 2 users will continue to get the 0.13.x version so it's not that they'll stop working.