Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added FreeBSD installation instructions #1361

Merged
merged 10 commits into from
Jun 5, 2024
Merged

docs: added FreeBSD installation instructions #1361

merged 10 commits into from
Jun 5, 2024

Conversation

ChromiumOS-Guy
Copy link
Contributor

@ChromiumOS-Guy ChromiumOS-Guy commented Jun 3, 2024

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

I added Tier 2 FreeBSD support using the linuxemu (aka Linux ABI)
which is very simple to setup.

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@ChromiumOS-Guy
Copy link
Contributor Author

forgot to mention that ani-skip doesn't work on FreeBSD , should add that warning first

@ChromiumOS-Guy ChromiumOS-Guy reopened this Jun 3, 2024
@71zenith
Copy link
Collaborator

71zenith commented Jun 4, 2024

Does ani-cli not work without linuxemu on FreeBSD?
We aim to remain posix compatible therefore it should run on any unix system without any layer.
It's just a shellscript afterall

@71zenith
Copy link
Collaborator

71zenith commented Jun 4, 2024

Am open to adding this to docs , but I would like to not have any more moving parts than necessary.

@ChromiumOS-Guy
Copy link
Contributor Author

I am not near my pc right now but I'll check if it works without linux emu (by disabling it)

also its not modified it just works (except ani-skip which i need to investigate further)

if by moving parts you mean more OSs to support that I agree , though I did state in the docs it is not supported so you are committing to nothing long term so I hope that helps (I'll try to support it though).

@ChromiumOS-Guy
Copy link
Contributor Author

also how does one enter debug mode on ani-cli because I didn't find any docs for it (though that's probably me being stupid)

@71zenith
Copy link
Collaborator

71zenith commented Jun 4, 2024

By moving parts, i meant linuxemu being a middleman

@71zenith
Copy link
Collaborator

71zenith commented Jun 4, 2024

also how does one enter debug mode on ani-cli because I didn't find any docs for it (though that's probably me being stupid)

debug?
if u just want to print the links then
ANI_CLI_PLAYER=debug ani-cli <args>
if u want it to print all the commands being run then
sh -x $(which ani-cli) <args>
sh -x is universal to any shell script so using it on ani-skip will also work

@71zenith
Copy link
Collaborator

71zenith commented Jun 4, 2024

I am not near my pc right now but I'll check if it works without linux emu (by disabling it)

also its not modified it just works (except ani-skip which i need to investigate further)

if by moving parts you mean more OSs to support that I agree , though I did state in the docs it is not supported so you are committing to nothing long term so I hope that helps (I'll try to support it though).

Fair, I've employed quite a number of hacks to get ani-skip working. Do report on what error ani-skip exits. Ill try to fix it.

@ChromiumOS-Guy
Copy link
Contributor Author

Np, and thanksfor the help with the debug stuff, I'll get to it in ~1.5h when I'm home.

turns out you don't need the Linux ABI
@ChromiumOS-Guy
Copy link
Contributor Author

yeah turns out you don't need linux emu , so all is good on that part (removed it from docs)
I just assumed that from some reason even though it says in the docs its for unix based OSs
which is just fun, sorry for the confusion.

@ChromiumOS-Guy
Copy link
Contributor Author

ChromiumOS-Guy commented Jun 4, 2024

well the debug stuff says all linkes fetched which is nice, also I noticed this:

dropbox Links Fetched
sharepoint Links Fetched
sed: 1: "s|^#.*x||g; s|,.*|p|g;  ...": unterminated substitute pattern
gogoanime Links Fetched

it seems to have no effect on functionality (and frankly I have no Idea what you do with sed editor)
also with debug I was able to get this:

$ ANI_CLI_PLAYER=debug ani-cli one piece --skip
Skip times not found!

so I just tried a movie (betting those probably had time skips) and it works just fine!

@ChromiumOS-Guy
Copy link
Contributor Author

forgot to say, yes --skip-title also works

@ChromiumOS-Guy
Copy link
Contributor Author

ChromiumOS-Guy commented Jun 4, 2024

so yeah everything works, no linuxemu required If you pull I'll probably update this if something needs to be changed (which knowing FreeBSD probably means never or maybe maybe when FreeBSD 15 drops proper)

@justchokingaround
Copy link
Collaborator

please remove the part where each dependency is installed on its own, it's redundant

@ChromiumOS-Guy
Copy link
Contributor Author

Sure!, done.
I just copied the style of the Steamdeck support but I don't mind at all.

@justchokingaround justchokingaround changed the title added Tier 2, FreeBSD support docs: added FreeBSD installation instructions Jun 5, 2024
@justchokingaround
Copy link
Collaborator

great, thanks for your contribution!

@justchokingaround justchokingaround merged commit 0ade589 into pystardust:master Jun 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants