fix: adapt to ani-skip update#1313
Conversation
Ani-Skip has been updated, with changed start arg now is -q [title] -e [episode] Small fix
|
There's a reason why I introduced getting MyAnimeList Id directly from ani-skip, cache it in Line no. 424 should be: [ "$skip_intro" = 1 ] && (dep_ch "ani-skip" || true) && mal_id=$(ani-skip -q "${skip_title:-${title}}")In [ "$skip_intro" = 1 ] && skip_flag="$(ani-skip -q "$mal_id" -e "$ep_no")"
|
The way synacktraa meant it to be.
|
Ahhh, i see. I really should have just waited for you to do that, sorry about that i got a bit overzealous... I changed it to that now. |
No problem. I hope you tested it once after making changes. |
|
I did... but something is still odd actually it doesnt work with every anime. let me make it a draft again.. i feel so embarassed right now whew, sorry if im causing issues :^) |
It may not be compatible with every anime due to the following reasons:
|
|
Yea, i figured out what the issue was i had, totally unrelated to this, had to do with my internet. |
|
I took the liberty to reword your PR title. Thanks for submitting |
removing unnecesary var
didnt work with seach because it loaded mal id before seach func.
|
Also bump the patch version please |
Co-authored-by: port19 <port19@port19.xyz>
Ani-Skip has been updated, with changed start arg
Pull Request Template
Type of change
Ani-Skip has been updated, with changed start arg, so tiny fix for that.
Description
I hope this is okay this way.
start arg now is -q [title] -e [episode]
Checklist
-chistory and continue work-ddownloads work-ssyncplay works-qquality works-vvlc works-eselect episode works-Sselect index works-rrange selection works--skipani-skip works--skip-titleani-skip title argument works--no-detachno detach works--duband regular (sub) mode both work-hhelp info is up to dateAdditional Testcases