Skip to content

fix: adapt to ani-skip update#1313

Merged
port19x merged 7 commits intopystardust:masterfrom
Woreec:patch-1
Apr 12, 2024
Merged

fix: adapt to ani-skip update#1313
port19x merged 7 commits intopystardust:masterfrom
Woreec:patch-1

Conversation

@Woreec
Copy link
Contributor

@Woreec Woreec commented Apr 9, 2024

Ani-Skip has been updated, with changed start arg

Pull Request Template

Type of change

Ani-Skip has been updated, with changed start arg, so tiny fix for that.

  • Bug fix
  • Feature
  • Documentation update

Description

I hope this is okay this way.
start arg now is -q [title] -e [episode]

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

Ani-Skip has been updated, with changed start arg
now is -q [title] -e [episode]
Small fix
@Woreec Woreec requested a review from Derisis13 as a code owner April 9, 2024 13:39
@Woreec Woreec marked this pull request as draft April 9, 2024 14:07
@Woreec Woreec marked this pull request as ready for review April 9, 2024 14:12
@synacktraa
Copy link

There's a reason why I introduced getting MyAnimeList Id directly from ani-skip, cache it in mal_id variable when parsing cli arguments.

Line no. 424 should be:

[ "$skip_intro" = 1 ] && (dep_ch "ani-skip" || true) && mal_id=$(ani-skip -q "${skip_title:-${title}}")

In play_episode function, it should be:

[ "$skip_intro" = 1 ] && skip_flag="$(ani-skip -q "$mal_id" -e "$ep_no")"

One can pass MyAnimeList ID directly to --skip-title and it would still work!

The way synacktraa meant it to be.
@Woreec
Copy link
Contributor Author

Woreec commented Apr 10, 2024

Ahhh, i see. I really should have just waited for you to do that, sorry about that i got a bit overzealous... I changed it to that now.

@synacktraa
Copy link

Ahhh, i see. I really should have just waited for you to do that, sorry about that i got a bit overzealous... I changed it to that now.

No problem. I hope you tested it once after making changes.

@Woreec Woreec marked this pull request as draft April 10, 2024 14:30
@Woreec
Copy link
Contributor Author

Woreec commented Apr 10, 2024

I did... but something is still odd actually it doesnt work with every anime. let me make it a draft again.. i feel so embarassed right now whew, sorry if im causing issues :^)

@synacktraa
Copy link

I did... but something is still odd actually it doesnt work with every anime. let me make it a draft again.. i feel so embarassed right now whew, sorry if im causing issues :^)

It may not be compatible with every anime due to the following reasons:

  • Certain titles may not be included in the aniskip database.
  • Occasionally, titles from allanime may not match the titles expected by MyAnimeList, resulting in incorrect IDs.

@Woreec
Copy link
Contributor Author

Woreec commented Apr 10, 2024

Yea, i figured out what the issue was i had, totally unrelated to this, had to do with my internet.
I tested it now with One piece, frieren and some more and they all work perfecly fine, including using --skip_title
So it really should work perfecly now.

@Woreec Woreec marked this pull request as ready for review April 10, 2024 14:51
@port19x port19x changed the title Ani-Skip update fix: adapt to ani-skip update Apr 11, 2024
@port19x
Copy link
Collaborator

port19x commented Apr 11, 2024

I took the liberty to reword your PR title. Thanks for submitting

Woreec added 2 commits April 11, 2024 14:58
removing unnecesary var
didnt work with seach because it loaded mal id before seach func.
@port19x
Copy link
Collaborator

port19x commented Apr 11, 2024

Also bump the patch version please

@port19x port19x merged commit 242db4e into pystardust:master Apr 12, 2024
@Woreec Woreec mentioned this pull request Apr 13, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants