Fixed erased folder when size cannot be handled #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
This is good to see. It was playing on my mind. If we can get a PyScript release out when this lands (for both MicroPython and Pyodide) that'd be awesome. 👍 |
|
@ntoll I am waiting for upstream to accept the MR but I can confirm it works great in MicroPython. To be honest, I could use the same code to patch Pyodide too but that doesn't feel like the best approach as I want to be in sync with upstream, not vice-versa so ... let's see, but I'll discuss and show more during today community call. |
WebReflection
force-pushed
the
better-fs
branch
4 times, most recently
from
cb86988 to
3a03c5d
Compare
WebReflection
force-pushed
the
better-fs
branch
from
3a03c5d to
832ae44
Compare
|
FYI upstream approved latest changes which I have applied and tested too ... I think this is good to go for MicroPython, let's hope Pyodide will also release soon enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR is based on this fix and it has been tested pyodide/pyodide#5434
The folder is currently not touched and the error is rightly propagated when it exceeds 4GB of data.
Warning
This fixes only the MicroPython port from upstream ... we should update Pyodide once their MR lands in their next release.