feat: add metadata to pyrra_objective #758
Open
+29
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akselleirv
force-pushed
the
feat/add-generic-metadata
branch
from
046d5f0 to
a9ee92b
Compare
|
@metalmatze Hello! Any chance to get it merged? |
metalmatze
reviewed
Dec 1, 2023
| if matcher.Name == "le" { | ||
| d, err := time.ParseDuration(matcher.Value + "s") // assume that the value is always in seconds | ||
| if err == nil { | ||
| labels["info"] = fmt.Sprintf("%.3f%% in %s must be faster than %s", o.Target*100, o.Window, d.String()) |
There was a problem hiding this comment.
Using %.3f%% formats the float using the 3 decimals. Maybe we can use strconv.FormatFloat(o.Target * 100, 'f', -1, 64) at the end and then use its string in the fmt.Sprintf.
| } | ||
| } | ||
| case Ratio: | ||
| labels["info"] = fmt.Sprintf("%.3f%% in %s", o.Target*100, o.Window) |
|
You can already add labels to pyrra_objective by adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.spec.descriptiontopyrra_objectivepyrra_objectivenamedinfowhich adds helpful metadata information about the SLO. Inspired from how the Pyrra UI adds latency information which makes it easier to understand what the latency SLO is measuring.Example of using the new metadata labels in the Grafana dashboard:
Relates to #745