-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix expectation computations in TraceEnum_ELBO by using adjoints to calculate marginals #2725
Conversation
Thanks for reviewing @eb8680 ! |
Now that pyro-ppl/funsor#445 has landed can you update the |
There is an unrelated to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to postpone merging this until after Pyro's 1.6 release, so as to avoid the need to release funsor
Addresses #2724.
Blocked by pyro-ppl/funsor#413.This implementation avoids exponentiation of individual terms as suggested by @eb8680 here.