Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expectation computations in TraceEnum_ELBO by using adjoints to calculate marginals #2725

Merged
merged 52 commits into from
Mar 10, 2021

Conversation

ordabayevy
Copy link
Member

@ordabayevy ordabayevy commented Dec 28, 2020

Addresses #2724.
Blocked by pyro-ppl/funsor#413.

This implementation avoids exponentiation of individual terms as suggested by @eb8680 here.

@ordabayevy ordabayevy changed the title Fixes expectation computations in TraceMarkovEnum_ELBO Fix expectation computations in TraceMarkovEnum_ELBO Dec 28, 2020
@eb8680 eb8680 added the Blocked label Mar 2, 2021
@ordabayevy
Copy link
Member Author

Thanks for reviewing @eb8680 !

@eb8680
Copy link
Member

eb8680 commented Mar 4, 2021

Now that pyro-ppl/funsor#445 has landed can you update the funsor[torch] dependency to the latest master? Should be good to merge if tests pass after that, although performance may be disappointing due to regressions in pyro-ppl/funsor#445.

eb8680
eb8680 previously requested changes Mar 4, 2021
setup.py Outdated Show resolved Hide resolved
@ordabayevy
Copy link
Member Author

There is an unrelated to this PR HTTPError: HTTP Error 403: Forbidden from cvae/main.py.

@fritzo fritzo added the Blocked label Mar 4, 2021
fritzo
fritzo previously requested changes Mar 4, 2021
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to postpone merging this until after Pyro's 1.6 release, so as to avoid the need to release funsor

@eb8680 eb8680 removed the Blocked label Mar 10, 2021
@eb8680 eb8680 dismissed fritzo’s stale review March 10, 2021 21:21

Pyro released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants