Simplify compartmental model interface #2445
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2426
This is a refactoring to prepare for a future SEIR model.
num_quant_bins
from.__init__()
(which henceforth accept only model-related args) to.fit()
(which accepts inference-related args). This reduces the burden of creating a new model class.SIRModel
toSimpleSIRModel
and adds documentation that "this model is intended to be forked, not customized"tau
so that it is actually the mean (there was an off-by-1 error).Tested