Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clamping bug in SIR example's quantize helpers #2433

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Fix clamping bug in SIR example's quantize helpers #2433

merged 2 commits into from
Apr 22, 2020

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Apr 22, 2020

This fixes a bug discovered and solved by @martinjankowiak

Tested

  • covered by existing tests
  • ran standard example and verified sanity

@fritzo fritzo mentioned this pull request Apr 22, 2020
Closed
38 tasks
@martinjankowiak martinjankowiak merged commit f7979a7 into dev Apr 22, 2020
@fritzo fritzo deleted the sir-fix-quantize branch April 28, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinjankowiak martinjankowiak martinjankowiak approved these changes

Assignees
No one assigned
Labels
awaiting review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzo @martinjankowiak