Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infer_discrete to work under the PyTorch jit #1646

Merged
merged 2 commits into from
Dec 7, 2018
Merged

Fix infer_discrete to work under the PyTorch jit #1646

merged 2 commits into from
Dec 7, 2018

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Dec 6, 2018 •
edited
Loading

This fixes a few jit warnings and patches opt_einsum (until dgasmith/opt_einsum#77 is released) so that infer_discrete works with the PyTorch jit.

Tested

  • added an example of a jitted viterbi decoder

@fritzo fritzo added this to the 0.3.0 release milestone Dec 6, 2018
neerajprad
neerajprad previously approved these changes Dec 6, 2018
View reviewed changes
@eb8680 eb8680 merged commit a9ef595 into dev Dec 7, 2018
@eb8680 eb8680 deleted the infer-discrete-jit branch December 7, 2018 03:02
@fritzo
Copy link
Member Author

fritzo commented Dec 7, 2018

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eb8680 eb8680 eb8680 approved these changes

@neerajprad neerajprad neerajprad left review comments

Assignees
No one assigned
Labels
awaiting review jit
Projects
None yet
Milestone
0.3.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@fritzo @neerajprad @eb8680