Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TraceEnum_ELBO jit tests, etc. #1590

Merged
merged 4 commits into from
Nov 30, 2018
Merged

Fix TraceEnum_ELBO jit tests, etc. #1590

merged 4 commits into from
Nov 30, 2018

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Nov 29, 2018

Addresses #1418

  • wraps packed.pack() in ignore_jit_warnings
  • avoids einsum when not necessary, using tensordot instead
  • fixes our einsum patch to allow multiple *operands (high priority fix!)
  • tweaks pyro.ops.einsum.paths objective function to not break when opt_einsum releases their next release

Note: although the jit tests are still marked xfail, they should start to pass as soon as we switch to the upcoming opt_einsum 2.3 release.

neerajprad
neerajprad previously approved these changes Nov 29, 2018
pyro/ops/einsum/paths.py Show resolved Hide resolved
eb8680
eb8680 previously approved these changes Nov 30, 2018
@eb8680
Copy link
Member

eb8680 commented Nov 30, 2018

Looks like some JIT-related test failures in Dice. I wonder why didn't those appear elsewhere already? Is it from a change in the nightly build?

@fritzo
Copy link
Member Author

fritzo commented Nov 30, 2018

Hmm weird, the failures only appear in opt_einsum release; I've been running opt_einsum master locally and tests all pass.

@dgasmith any chance you could cut a minor opt_einsum release soon?

@dgasmith
Copy link

Writing the release notes now. Should cut tomorrow.

@fritzo fritzo dismissed stale reviews from eb8680 and neerajprad via 8ff61d2 November 30, 2018 01:18
@eb8680 eb8680 merged commit 4df40d0 into dev Nov 30, 2018
@eb8680 eb8680 deleted the fix-dice-jit branch November 30, 2018 07:17
@dgasmith
Copy link

dgasmith commented Dec 1, 2018

opt_einsum 2.3.1 is now on Conda-forge and PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants