Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch to Integrate(Delta, ...) in normalize_integrate_contraction #551

Merged
merged 3 commits into from
Sep 24, 2021

Conversation

ordabayevy
Copy link
Member

@ordabayevy ordabayevy commented Sep 23, 2021

Addresses #550 .

pytest contrib/funsor/ tests pass locally:

contrib/funsor/test_enum_funsor.py .........................x...................x.x.....                [ 16%]
contrib/funsor/test_infer_discrete.py ..........................                                        [ 23%]
contrib/funsor/test_named_handlers.py ......                                                            [ 25%]
contrib/funsor/test_pyroapi_funsor.py ................x                                                 [ 30%]
contrib/funsor/test_tmc.py ............................................................................ [ 53%]
............                                                                                            [ 57%]
contrib/funsor/test_valid_models_enum.py ................xxxx....................................       [ 74%]
contrib/funsor/test_valid_models_plate.py ........X.X.X.X................                               [ 83%]
contrib/funsor/test_valid_models_sequential_plate.py .........                                          [ 86%]
contrib/funsor/test_vectorized_markov.py ........................XXXXXXXXXXXX.....x...                  [100%]

============================ 306 passed, 9 xfailed, 16 xpassed in 91.92s (0:01:31) ============================

@ordabayevy ordabayevy added the WIP label Sep 23, 2021
@ordabayevy ordabayevy changed the title Dispatch to Integrate(Delta, ...) and dice_factor as log_density Dispatch to Integrate(Delta, ...) in normalize_integrate_contraction Sep 23, 2021
@eb8680
Copy link
Member

eb8680 commented Sep 24, 2021

What went wrong with the dice_factor change?

@ordabayevy
Copy link
Member Author

Wasn't sure if it should be in the same PR. There is a change I had to make in the test: remove terms[0] because .sample there now returns just Delta instead of Contraction (result+dice_factor) - hope that doesn't affect the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants