refactor(packaging): Use SQLAlchemy event for Filename registry (Fixes #576) #18934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #576.
This PR refactors the logic for adding new filenames to the
file_registry(Filenamemodel).As suggested by the issue, this logic was previously handled inline in the
file_uploadview, which is not ideal. This PR moves the logic to a SQLAlchemy event listener.Changes:
request.db.add(Filename(filename=filename))call fromwarehouse/forklift/legacy.py.@event.listens_for(File, "after_insert")hook towarehouse/packaging/models.py.This new hook automatically inserts the
File.filenameinto thefile_registrytable when a newFileis created.To resolve the
SAWarningabout modifying a session during a flush, the hook uses a directconnection.execute()operation.Proof / Test Output:
The existing tests in
tests/unit/forklift/test_legacy.pystill pass, which confirms the filename logging logic was successfully moved.