Ignore case when verifying GitLab/GitHub URLs #16899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkaMaul
commented
Oct 16, 2024
woodruffw
reviewed
Oct 16, 2024
facutuesca
reviewed
Oct 16, 2024
Simplify code. Co-authored-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
facutuesca
reviewed
Oct 16, 2024
Co-authored-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
di
approved these changes
Nov 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug reported in #16666
by adding a new field in.OIDCPublisherMixinregarding the case-sensitivity of URL verificationBoth GitLab and GitHub works with case-insensitive slugs but ActiveState does not 1.
/cc @facutuesca @woodruffw