[oidc] Remove User.has_oidc_beta_access column
#13461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
changed the title
User.has_oidc_beta_access columnUser.has_oidc_beta_access column
miketheman
approved these changes
Apr 20, 2023
|
|
||
| def upgrade(): | ||
| conn = op.get_bind() | ||
| conn.execute("SET statement_timeout = 120000") |
There was a problem hiding this comment.
Do you expect a DROP COLUMN to take a long time? In a particularly busy table, I guess getting a lock might take a while, but is users updated that much?
There was a problem hiding this comment.
I don't, but I figure this doesn't hurt given recent lock contention.
di
force-pushed
the
remove-has_oidc_beta_access-column
branch
from
f04c612 to
a1c101e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #13460.