chore: handle sass warnings #12742
Merged
chore: handle sass warnings #12742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Dart Sass has deprecated inline division. Refs: https://sass-lang.com/documentation/breaking-changes/slash-div We vendor the `bourbon` and `neat` sass libraries, but have no clear path for upgrading them at this time. `neat` is deprecated, and will not receive any further updates, so I don't feel too bad about modifying a library right now. We should evaluate what functionality we use from the libraries and determine potential replacements, but until that time we should not emit deprecation warnings during compilation for this issue. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
We reuse the concept of "half of a spacing unit" frequently. We can then use the `math.div()` function to return the desired value, as Dart Sass 2.0.0 will disallow usage of `/` outside `calc` or `math.div`, and prevents the deprecation warning. Refs: https://sass-lang.com/d/slash-div Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Similar to `$half-spacing-unit`, extract to a variable and refactor to use `math.div()`. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
added
CSS/SCSS
13 tasks
di
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #12728
Commit descriptions contain richer context.