Remove unneeded NodeJS dependencies #12379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a deprecated library and replace with a native test shim.
node-webcrypto-ossl has been deprecated. This module was created in
2015 because at the time the Node team did not feel the need to
have two crypto interfaces and they already had one before
WebCrypto was defined
Refs: https://www.npmjs.com/package/node-webcrypto-ossl
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
jsdom 13.2.0 added direct support for MutationObserver, and recommends removing all workarounds. We're on version 19.0. Refs: jsdom/jsdom#639 (comment) Signed-off-by: Mike Fiedler <miketheman@gmail.com>
With `fetch()` being available to all modern browsers, we no longer need to provide this polyfill. Remove related `imports-loader` and `exports-loader` as well. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
13 tasks
ewdurbin
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit describes in more detail the whys and wherefores.
TL,DR: Remove no-longer needed dependencies and replace with modern built-in functionality.