-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade NodeJS to 16.x #12288
Conversation
I decided to not include the removal of the referenced test library in this changeset, rather let's let this one go out with no other changes and confirm things are happy before further changes. |
The lockfile grew significantly in size, as it's now version 2 of the lockfile with speed improvements. |
c30068c
to
d1a3521
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the full diff: https://gist.github.com/di/8a396464d5b600cda5df2124edb1ba2b
This is somewhat hard to review due to the change in package-lock.json
versions, but looks right to me.
We should probably wait until Monday to merge this so we can babysit it in case it fails for some reason.
Node 14 ends support in April 2023. Node 16 will remain supported until September 2023. Upgrading to Node 16 allows removal of the `node-webcrypto-ossl` dependency used in tests. `package-lock.json` updated for the new lockfile format with npm 8 and removes some no longer needed dependencies. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
d1a3521
to
c5f2137
Compare
@ewdurbin would you have some time to ship this today and keep an eye on it for a bit? |
This rolled out successfully, thanks @miketheman! |
Node 14 ends support in April 2023.
Node 16 will remain supported until September 2023.
Upgrading to Node 16 allows removal of the
node-webcrypto-ossl
dependency used in tests.package-lock.json
updated for the new lockfile format with npm 8 and removes some no longer needed dependencies.Signed-off-by: Mike Fiedler miketheman@gmail.com