Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade NodeJS to 16.x #12288

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Conversation

miketheman
Copy link
Member

Node 14 ends support in April 2023.
Node 16 will remain supported until September 2023.

Upgrading to Node 16 allows removal of the node-webcrypto-ossl dependency used in tests.

package-lock.json updated for the new lockfile format with npm 8 and removes some no longer needed dependencies.

Signed-off-by: Mike Fiedler miketheman@gmail.com

@miketheman miketheman requested a review from a team as a code owner September 29, 2022 02:48
@miketheman
Copy link
Member Author

I decided to not include the removal of the referenced test library in this changeset, rather let's let this one go out with no other changes and confirm things are happy before further changes.

@miketheman
Copy link
Member Author

The lockfile grew significantly in size, as it's now version 2 of the lockfile with speed improvements.
https://docs.npmjs.com/cli/v8/configuring-npm/package-lock-json

@miketheman miketheman force-pushed the miketheman/upgrade-node-runtime branch 2 times, most recently from c30068c to d1a3521 Compare September 30, 2022 21:35
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the full diff: https://gist.github.com/di/8a396464d5b600cda5df2124edb1ba2b

This is somewhat hard to review due to the change in package-lock.json versions, but looks right to me.

We should probably wait until Monday to merge this so we can babysit it in case it fails for some reason.

@di di requested a review from ewdurbin September 30, 2022 21:52
Node 14 ends support in April 2023.
Node 16 will remain supported until September 2023.

Upgrading to Node 16 allows removal of the `node-webcrypto-ossl`
dependency used in tests.

`package-lock.json` updated for the new lockfile format with npm 8 and
removes some no longer needed dependencies.

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman miketheman force-pushed the miketheman/upgrade-node-runtime branch from d1a3521 to c5f2137 Compare October 4, 2022 03:03
@miketheman
Copy link
Member Author

@ewdurbin would you have some time to ship this today and keep an eye on it for a bit?

@miketheman miketheman mentioned this pull request Oct 8, 2022
13 tasks
@di di merged commit 941078f into pypi:main Oct 10, 2022
@di
Copy link
Member

di commented Oct 10, 2022

This rolled out successfully, thanks @miketheman!

@miketheman miketheman deleted the miketheman/upgrade-node-runtime branch October 11, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants