chore(ci): update ci to test against node 14.19.1 #12264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
force-pushed
the
miketheman/upgrade-node-in-ci
branch
4 times, most recently
from
267374c
to
6d87416
Compare
We didn't maintain parity with Dockerfile* when upgrading last time. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/upgrade-node-in-ci
branch
from
6d87416
to
a8f9726
Compare
ewdurbin
approved these changes
Sep 29, 2022
|
Thanks Mike! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't maintain parity when upgrading last time.
Instead of trying to keep two items in sync, use theengineskeywordin
package.jsonto set the desired node version, and have the CIaction use it for setup.
I have yet to find a way to use the same value in aDockerfiledefinition, but one fewer location seems better.
Refs: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#enginesFunctionality to support this not yet released on
actions/setup-node🤦Signed-off-by: Mike Fiedler miketheman@gmail.com