Upgrade webauthn #11917
Merged
Upgrade webauthn #11917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
di
approved these changes
Jul 25, 2022
miketheman
approved these changes
Jul 26, 2022
woodruffw
pushed a commit
to trail-of-forks/warehouse
that referenced
this pull request
Jul 27, 2022
SamirPS
pushed a commit
to SamirPS/warehouse
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
webauthn1.6.0 added new mandatory parameters to some of the classes, we don't produce these classes in normal code, they are produced bywebauthnby parsing the client responses, but we do produce them in tests. To solve that we just chuck some dummy data into those fields in our tests.Closes #11846