Skip to content

correct my name #11209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2022
Merged

correct my name #11209

merged 1 commit into from
Apr 19, 2022

Conversation

ewdurbin
Copy link
Member

dev db dump is years old, screenshots using my user account are painful

dev db dump is years old, screenshots using my user account are painful
@ewdurbin ewdurbin enabled auto-merge (squash) April 19, 2022 13:53
Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but also: we've had a lot of migrations since the last dump, which makes tests slow. Maybe we're due to bring the dev db up to date and fix this while we're at it.

@ewdurbin
Copy link
Member Author

I think we've approached this a few times and the issue is that the test.pypi.org DB is now much larger.

This will result in an even larger clone unless we offload the dev db to git-fs or some remote storage.

@ewdurbin
Copy link
Member Author

Also tests do not rely on this DB dump, they build a clean DB?

@ewdurbin ewdurbin merged commit acc258d into main Apr 19, 2022
@ewdurbin ewdurbin deleted the kindness branch April 19, 2022 13:58
@di
Copy link
Member

di commented Apr 19, 2022

I didn't mean dump from TestPyPI, I meant run initdb, apply migrations, fix this issue, and dump the local DB back to the file.

@ewdurbin
Copy link
Member Author

That will still generate another ~60MB file in the git-tree :/

@miketheman
Copy link
Member

Brings up an interesting question on whether we should try to restore from a DB Dump, or use Factory Boy to generate known seed data for development purposes, since the test suite does generate its own data.

If this is desirable for better developer experience, that's something we could pursue, but it does continue the drift between the "real" database schema in prod vs what we create in dev/test.

1 similar comment
@miketheman
Copy link
Member

Brings up an interesting question on whether we should try to restore from a DB Dump, or use Factory Boy to generate known seed data for development purposes, since the test suite does generate its own data.

If this is desirable for better developer experience, that's something we could pursue, but it does continue the drift between the "real" database schema in prod vs what we create in dev/test.

domdfcoding pushed a commit to domdfcoding/warehouse that referenced this pull request Jun 7, 2022
dev db dump is years old, screenshots using my user account are painful
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants