-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add mypy #10874
chore: add mypy #10874
Commits on Mar 7, 2022
-
chore(deps): install mypy in lint.in
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 187169c - Browse repository at this point
Copy the full SHA 187169cView commit details -
chore(deps): include more types-* packages for mypy
These were suggested from running mypy on the codebase. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f9be9ac - Browse repository at this point
Copy the full SHA f9be9acView commit details -
Set configuration for mypy. Exclude some of the subdirectories we are not interested in testing to speed up mypy execution. Ignore any 3rd party modules that we do not have types for yet. Added links that I could find to help track completion. Does **not** set `strict` mode yet, since that's a bigger lift. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ad707cd - Browse repository at this point
Copy the full SHA ad707cdView commit details -
Eventually this command should fold into `bin/lint` and be removed. For now, it's a convenient execution wrapper. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fffeadb - Browse repository at this point
Copy the full SHA fffeadbView commit details -
lint: ignore dynamic properties
Callables are receiving dynamic attributes, something that isn't "usual". See python/mypy#708 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 49e5822 - Browse repository at this point
Copy the full SHA 49e5822View commit details -
See python/mypy#4226 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4afc312 - Browse repository at this point
Copy the full SHA 4afc312View commit details -
lint: ignore hybrid_property repeat definitions
Part of the SQLAlchemy extensions, which do not yet have reliable stubs/plugins. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 83631ae - Browse repository at this point
Copy the full SHA 83631aeView commit details -
lint: ignore sqlalchemy declarative
Should come along with sqlalchemy stubs. See: https://docs.sqlalchemy.org/en/14/orm/extensions/mypy.html#using-declared-attr-and-declarative-mixins Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b1e978b - Browse repository at this point
Copy the full SHA b1e978bView commit details -
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ed4be0f - Browse repository at this point
Copy the full SHA ed4be0fView commit details -
lint: interface methods shouldn't use self
Surfaced via mypy, corrected! Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5451699 - Browse repository at this point
Copy the full SHA 5451699View commit details -
Surfaced via mypy, corrected. Unclear why this wouldn't have been caught by other tools. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5c754ce - Browse repository at this point
Copy the full SHA 5c754ceView commit details -
lint: rename internal variable
mypy detected this as a type mismatch, as the internal variable name was shadowing the externally-supplied one, and changing the type. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 69a07b9 - Browse repository at this point
Copy the full SHA 69a07b9View commit details -
lint: ignore flake8 line too long for ignored types
Adding a `# type: ignore` comment to a couple of places triggered flake8's line too long check. Running `make reformat` did nothing for these - black has outstanding design issues with line length and comments. See psf/black#1713 for one example. Instead of changing the line structure to accommodate, ignore these two cases, at least until the types can be fixed and the comments removed. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3f1b9bb - Browse repository at this point
Copy the full SHA 3f1b9bbView commit details
Commits on Mar 9, 2022
-
Revert "chore: add mypy runner script"
This reverts commit fffeadb.
Configuration menu - View commit details
-
Copy full SHA for 37f6038 - Browse repository at this point
Copy the full SHA 37f6038View commit details -
test: include mypy in lint execution
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c0f245a - Browse repository at this point
Copy the full SHA c0f245aView commit details -
chore(deps): include itsdangerous type stubs
Until itsdangerous 2.0 is included, this types package is needed. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3dbe8df - Browse repository at this point
Copy the full SHA 3dbe8dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for df2be72 - Browse repository at this point
Copy the full SHA df2be72View commit details