fix(test): Restore mtime of py_info.py in test #2938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test `test_py_info_cache_invalidation_on_py_info_change` modifies the `py_info.py` script to test cache invalidation. However, it did not restore the original modification time of the file, which caused `.pyc` files to be invalidated, leading to QA notices in some packaging environments. This change remedies the situation by saving the file's stat info before modification and restoring the atime and mtime in the test's finally block. This ensures that the file's timestamp is not permanently altered by the test run. Fixes pypa#2933 Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
gaborbernat
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
test_py_info_cache_invalidation_on_py_info_changemodifies thepy_info.pyscript to test cache invalidation. However, it did not restore the original modification time of the file, which caused.pycfiles to be invalidated, leading to QA notices in some packaging environments.This change remedies the situation by saving the file's stat info before modification and restoring the atime and mtime in the test's finally block. This ensures that the file's timestamp is not permanently altered by the test run.
Fixes #2933
tox -e fix)docs/changelogfolder