Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Windows zipapp and drop 3.7 support #2783

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Oct 17, 2024

Resolves pypa/distlib#235
Resolves #2784

Both change sets are needed to make the CI pass.

Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat changed the title Fix broken Windows zipapp Fix broken Windows zipapp and drop 3.7 support Oct 18, 2024
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit f73a2f3 into pypa:main Oct 18, 2024
0 of 2 checks passed
@gaborbernat gaborbernat deleted the distlib branch October 18, 2024 01:25
@henryiii
Copy link

Not sure it was expected, but this change also breaks making a 3.7 venv, not just running on 3.7. Seen in pypa/pyproject-metadata#207; nox can no longer target 3.7.

@gaborbernat
Copy link
Contributor Author

That is very much expected. tox does https://tox.wiki/en/4.23.0/faq.html#testing-end-of-life-python-versions NOx should do similar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest distlib breaks on Windows distlib 0.3.9 breaks virtualenv in zipapp on Windows
2 participants