Skip to content

Conversation

@DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Sep 23, 2023

These refurb suggestions appear to improve readability.

The changes seem trivial to me, hence the lack of news fragment.

Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

These appear to improve readability.
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with most of these .

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Sep 23, 2023

I don't agree with most of these .

Why?

esafak pushed a commit to esafak/virtualenv that referenced this pull request Aug 1, 2025
The cache for PythonInfo is now invalidated if the PythonInfo class
changes. I achieved this by hashing the py_info.py file and storing
the hash in the cache. When loading from the cache, the hash is
recomputed and compared with the stored hash. If they don't match, the cache is invalidated.

Fixes pypa#2647
esafak pushed a commit to esafak/virtualenv that referenced this pull request Aug 1, 2025
The cache for PythonInfo is now invalidated if the PythonInfo class
changes. I achieved this by hashing the py_info.py file and storing the hash in the cache. When loading from the cache, the hash is recomputed and compared with the stored hash. If they don't match, the cache is invalidated.

Fixes pypa#2647

Signed-off-by: Emre Şafak <3928300+esafak@users.noreply.github.com>
@esafak esafak mentioned this pull request Aug 1, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants