Skip to content

update nushell's str collect command to str join #2532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 31, 2023
Merged

update nushell's str collect command to str join #2532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
984dd65
update nushell's str collect command to str join
fdncred Mar 30, 2023
d4e200f
add changelog fragment
fdncred Mar 30, 2023
5e568a1
empty-commit
fdncred Mar 31, 2023
ce1e853
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/changelog/2532.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The nushell command 'str collect' has been superseded by the 'str join' command. The activate.nu script has
been updated to reflect this change.
4 changes: 2 additions & 2 deletions src/virtualenv/activation/nushell/activate.nu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export-env {
)

let venv_path = ([$virtual_env $bin] | path join)
let new_path = ($old_path | prepend $venv_path | str collect $path_sep)
let new_path = ($old_path | prepend $venv_path | str join $path_sep)

let new_env = {
$path_name : $new_path
Expand Down Expand Up @@ -102,7 +102,7 @@ export-env {
})

$new_env | merge {
_OLD_VIRTUAL_PATH : ($old_path | str collect $path_sep)
_OLD_VIRTUAL_PATH : ($old_path | str join $path_sep)
_OLD_PROMPT_COMMAND : $old_prompt_command
PROMPT_COMMAND : $new_prompt
VIRTUAL_PROMPT : $virtual_prompt
Expand Down