Sepcify the encoding #2515
Merged
Sepcify the encoding #2515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00
force-pushed
the
specify-default-encoding
branch
from
1dcd472 to
5f8bc62
Compare
Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00
force-pushed
the
specify-default-encoding
branch
from
5f8bc62 to
a6b4f12
Compare
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00
force-pushed
the
specify-default-encoding
branch
from
a1658f3 to
2b747e8
Compare
gaborbernat
requested changes
Mar 10, 2023
| @@ -0,0 +1 @@ | |||
| Do not assume the default encoding. | |||
There was a problem hiding this comment.
This is a bugfix, not misc.
Signed-off-by: Filipe Laíns <lains@riseup.net>
gaborbernat
approved these changes
Mar 10, 2023
tarpas
pushed a commit
to tarpas/virtualenv
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)
tox -e fix)docs/changelogfolderThis PR sets
PYTHONWARNDEFAULTENCODINGwhen running the tests, see PEP 597, and explicitly specifies the encoding on all affected calls.