Skip to content

new patch versions of pip, setuptools & wheel are not considered for 28 days #2266

@mayeut

Description

@mayeut

Issue

New patch versions of pip, setuptools & wheel are not considered for 28 days.
The expected behavior is that patch versions are always considered "immediately" (after the 1 hour grace period for CI).

Environment

up-to-date main branch: 51408e6

tox -e dev

Reproducer

I guess the test was buggy ?

diff --git a/tests/unit/seed/wheels/test_periodic_update.py b/tests/unit/seed/wheels/test_periodic_update.py
index 9b32770..282297f 100644
--- a/tests/unit/seed/wheels/test_periodic_update.py
+++ b/tests/unit/seed/wheels/test_periodic_update.py
@@ -107,12 +107,13 @@ def test_periodic_update_stops_at_current(mocker, session_app_data, for_py_versi
 
 def test_periodic_update_latest_per_patch(mocker, session_app_data, for_py_version):
     current = get_embed_wheel("setuptools", for_py_version)
+    expected_path = wheel_path(current, (0, 1, 2))
     now, completed = datetime.now(), datetime.now() - timedelta(days=29)
     u_log = UpdateLog(
         started=completed,
         completed=completed,
         versions=[
-            NewVersion(wheel_path(current, (0, 1, 2)), completed, now - timedelta(days=1)),
+            NewVersion(expected_path, completed, now - timedelta(days=1)),
             NewVersion(wheel_path(current, (0, 1, 1)), completed, now - timedelta(days=30)),
             NewVersion(filename=str(current.path), found_date=completed, release_date=now - timedelta(days=2)),
         ],
@@ -121,7 +122,7 @@ def test_periodic_update_latest_per_patch(mocker, session_app_data, for_py_versi
     mocker.patch("virtualenv.app_data.via_disk_folder.JSONStoreDisk.read", return_value=u_log.to_dict())
 
     result = periodic_update("setuptools", None, for_py_version, current, [], session_app_data, False, os.environ)
-    assert result.path == current.path
+    assert str(result.path) == expected_path
 
 
 def wheel_path(wheel, of):

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions