Add tests for MANIFEST.in #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-moth
force-pushed
the
manifest-tests
branch
2 times, most recently
from
4992078 to
b3b9c65
Compare
|
OK, got the tests passing. Compatibility across so many versions and platforms is apparently tricky! |
mx-moth
force-pushed
the
manifest-tests
branch
from
d0f602d to
498f86b
Compare
|
Awesome. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking in to finishing #610, but found that there were no tests for
MANIFEST.inthat I could find. As setuptools customises the FileList a little bit, and #610 customises it some more, some tests for this would be sensible.I wrote some tests that work much like
setuptools/tests/test_sdist.py, by creating some files and running with various MANIFEST.in files.I also copied the FileList tests from distutils, modifying them slightly to fit with py.test and the setuptools environment.
This way, it will be easy to verify that any modifications done to setuptools retain compatibility with distutils.