Repository navigation
Conversation
build_py copies nested .py package_data as modules with preserve_mode=False first. After v84's nanosecond mtime copy, the later package_data copy is skipped as up-to-date, so +x is dropped from wheels. Always apply the source mode after that copy.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #5296.
Since setuptools 84.0.0,
package_datafiles that are also Python modules (for example a nestedscripts/*.pypicked up as a PEP 420 package) lost their executable bit in wheels.build_pycopies those.pyfiles first as modules withpreserve_mode=False, then as package data withpreserve_mode=True. v84 started writing nanosecond mtimes, so the second copy is skipped as up-to-date and the+xbit from the source never gets applied.build_package_datanow always applies the source permission bits after the copy (thenmake_writable, same as before).Closes #5296
Pull Request Checklist
newsfragments/].