Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with pypa/distutils@c97a3db2f #4778

Merged
merged 48 commits into from
Dec 27, 2024
Merged

Merge with pypa/distutils@c97a3db2f #4778

merged 48 commits into from
Dec 27, 2024

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Dec 27, 2024

  • Use minimum requirement for jaraco.functools
  • use a real boolean (False) default for display_option_names generated attributes
  • Accept an Iterable at runtime for Extension
  • Add more tests to cover different iterables
  • Delegate to os.fspath for type checking
  • Fix typo
  • Return real boolean from copy_file
  • Fix test_mkpath_exception_uncached
  • Set Py_GIL_DISABLED=1 for free threading on Windows
  • Link to setuptools issue
  • Trim the comment a bit.
  • 👹 Feed the hobgoblins (delint).
  • Use alternate spelling for flavor attribute.
  • Only apply workaround on required Pythons.
  • Let pathlib resolve the flavor.
  • 👹 Feed the hobgoblins (delint).
  • Run Ruff 0.8.0
  • Add review suggestions around code comments
  • Use TypeError instead of AssertionError
  • UP031 manual fixes for Ruff 0.8.0
  • Make reinitialize_command's return type Generic when "command" argument is a Command
  • Coerce Distribution.script_args to list
  • Remove py38 compat modules
  • Remove UP036 exclusion.
  • Prefer the standard format for imports, even though it's unnecessarily repetitive.
  • type Distribution.get_command_obj to not return None with create=True
  • ClassVar classvar mutables and tuple from typeshed
  • 👹 Feed the hobgoblins (delint).
  • Use CFLAGS if set as-is, match CXXFLAGS behavior
  • 👹 Feed the hobgoblins (delint).

Summary of changes

Closes #4662

Pull Request Checklist

anderstheet and others added 30 commits October 8, 2024 08:30
Co-Authored-By: Avasam <samuel.06@hotmail.com>
Co-authored-by: Avasam <samuel.06@hotmail.com>
When free threaded CPython is installed from the official Windows
installer it doesn't have the macro `Py_GIL_DISABLED` properly set
becuase its `pyconfig.h` file is shared across the co-installed default
build.

Define the macro when building free threaded Python extensions on
Windows so that each individual C API extension doesn't have to work
around this limitation.

See #4662
Set `Py_GIL_DISABLED=1` for free threaded Python on Windows.
…nimum-requirement-jaraco.functools

Use minimum requirement for jaraco.functools
Use a real boolean (False) default for display_option_names generated attributes
…al-boolean

Return real boolean from copy_file
…eption_uncached

Fix test_mkpath_exception_uncached
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
Co-authored-by: Avasam <samuel.06@hotmail.com>
Run Ruff 0.8.0 (automated fixes only)
…e_command

Make reinitialize_command's return type Generic when "command" argument is a Command
jaraco and others added 18 commits December 26, 2024 20:51
…nual-fixes

UP031 manual fixes for Ruff 0.8.0
Coerce Distribution.script_args to list
…nsion-sources

Accept any non-string iterable for `distutils.Extension`'s sources
…rload

type `Distribution.get_command_obj` to not return `None` with `create=True`
…nd-tuple

Type ClassVar mutables and tuple from typeshed
Since 2c93711, CXXFLAGS is used
as-is if set in the envionment rather than clobbered by whatever
CPython happened to be built with.

Do the same for CFLAGS: use it as-is if set in the environment, don't
prepend CPython's saved flags.

Fixes: pypa/distutils#299
Use CFLAGS if set as-is, match CXXFLAGS behavior
@jaraco
Copy link
Member Author

jaraco commented Dec 27, 2024

The docs build is failing with this warning (treated as error):

/Users/jaraco/code/pypa/setuptools/docs/userguide/quickstart.rst:200: WARNING: term not in glossary: 'namespace-package' [ref.term]

The same error occurs when building main, but only on the first run. On a subsequent run, the docs build completes normally. This failure was apparently not an issue four weeks ago and started failing main here.

@jaraco jaraco closed this Dec 27, 2024
@jaraco jaraco reopened this Dec 27, 2024
@jaraco jaraco merged commit 263c321 into main Dec 27, 2024
53 of 58 checks passed
@jaraco jaraco deleted the feature/distutils-c97a3db2f branch December 27, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Py_GIL_DISABLED not defined in "free-threaded" Windows C-API extensions
6 participants