-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge with pypa/distutils@c97a3db2f #4778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Avasam <samuel.06@hotmail.com>
When free threaded CPython is installed from the official Windows installer it doesn't have the macro `Py_GIL_DISABLED` properly set becuase its `pyconfig.h` file is shared across the co-installed default build. Define the macro when building free threaded Python extensions on Windows so that each individual C API extension doesn't have to work around this limitation. See #4662
Set `Py_GIL_DISABLED=1` for free threaded Python on Windows.
…nimum-requirement-jaraco.functools Use minimum requirement for jaraco.functools
Use a real boolean (False) default for display_option_names generated attributes
…al-boolean Return real boolean from copy_file
…eption_uncached Fix test_mkpath_exception_uncached
Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> Co-authored-by: Avasam <samuel.06@hotmail.com>
Run Ruff 0.8.0 (automated fixes only)
…e_command Make reinitialize_command's return type Generic when "command" argument is a Command
…modules Remove py38 compat modules
…nual-fixes UP031 manual fixes for Ruff 0.8.0
Coerce Distribution.script_args to list
…nsion-sources Accept any non-string iterable for `distutils.Extension`'s sources
…rload type `Distribution.get_command_obj` to not return `None` with `create=True`
…nd-tuple Type ClassVar mutables and tuple from typeshed
Since 2c93711, CXXFLAGS is used as-is if set in the envionment rather than clobbered by whatever CPython happened to be built with. Do the same for CFLAGS: use it as-is if set in the environment, don't prepend CPython's saved flags. Fixes: pypa/distutils#299
Use CFLAGS if set as-is, match CXXFLAGS behavior
The docs build is failing with this warning (treated as error):
The same error occurs when building |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterable
at runtime forExtension
os.fspath
for type checkingPy_GIL_DISABLED=1
for free threading on WindowsTypeError
instead ofAssertionError
Distribution.get_command_obj
to not returnNone
withcreate=True
Summary of changes
Closes #4662
Pull Request Checklist
newsfragments/
.(See documentation for details)