Skip to content

Show more info from pkg_resources deprecation #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abravalheri merged 3 commits into from
Jun 19, 2023
Merged

Show more info from pkg_resources deprecation #3920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
500f0a5
Show source location and link to more info, from pkg_resources deprec…
brondsem May 8, 2023
1ebdba5
Use issue_warning helper to get best stacklevel (sometimes it could p…
brondsem May 9, 2023
98537a9
Add news fragment
abravalheri May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog.d/3920.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Add a link to deprecation warning in ``pkg_resources`` and improve
``stacklevel`` for better visibility.
7 changes: 4 additions & 3 deletions pkg_resources/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@
_namespace_packages = None


warnings.warn("pkg_resources is deprecated as an API", DeprecationWarning)
warnings.warn("pkg_resources is deprecated as an API. "
"See https://setuptools.pypa.io/en/latest/pkg_resources.html",
DeprecationWarning, stacklevel=2)


_PEP440_FALLBACK = re.compile(r"^v?(?P<safe>(?:[0-9]+!)?[0-9]+(?:\.[0-9]+)*)", re.I)
Expand Down Expand Up @@ -1659,10 +1661,9 @@ def _validate_resource_path(path):

# for compatibility, warn; in future
# raise ValueError(msg)
warnings.warn(
issue_warning(
msg[:-1] + " and will raise exceptions in a future release.",
DeprecationWarning,
stacklevel=4,
)

def _get(self, path):
Expand Down