Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case sensitivity of entry point names and keys in setup.cfg. Fixes #1937 #2580

Merged

Conversation

melissa-kun-li
Copy link
Contributor

@melissa-kun-li melissa-kun-li commented Feb 24, 2021

Summary of changes

Closes #1937

To address the bug of entry point names being made lower-case by Setuptools, this fix preserves case-sensitivity of keys in setup.cfg by changingConfigParser to become case-sensitive. Edit: by extension this will also address any issues about keys in setup.cfg not retaining case-sensitivity such as in #2480

Pull Request Checklist

@melissa-kun-li melissa-kun-li changed the title Fix entry points name case sensitivity and change key sensitivity in setup.cfg Fix case sensitivity of entry point names and keys in setup.cfg. Fixes #1937 Feb 24, 2021
Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Looks like a simple change, but I know it involved a great deal of work to figure it out. This change will help a lot of people. One small request above then it's good to go.

setuptools/tests/test_config.py Outdated Show resolved Hide resolved
@jaraco jaraco merged commit 72c7a6c into pypa:main Feb 25, 2021
@jaraco
Copy link
Member

jaraco commented Feb 25, 2021

Releasing as 53.1.0. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup.cfg: entry_points keys are made lowercase
2 participants