-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two Assertion failures on Windows tests (script_header) #37
Comments
Original comment by arfrever (Bitbucket: arfrever, GitHub: arfrever): Shebangs do not work at all on Windows, so these tests could be skipped on Windows. Quotes in shebang are interpreted as integral part of path (at least on Linux):
Such quotes should not be added around a path with spaces. Probably tests should be skipped in such situation. |
Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco): I believe that both setuptools and the Windows py launcher both honor the shebang in Python scripts and more importantly do a better job of it than Unix does, supporting valid filenames with spaces in them. Furthermore, I'd like to get these tests passing as they're not only testing the headers. |
* Replace pep517.build with build Resolves #30 * Prefer simple usage Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
* Use `extend-ignore` in flake8 config This option allows to add extra ignored rules to the default list instead of replacing it. The default exclusions are: E121, E123, E126, E226, E24, E704, W503 and W504. Fixes #28. Refs: * https://github.com/pypa/setuptools/pull/2486/files#r541943356 * https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-extend-ignore * https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-ignore * Enable complexity limit. Fixes jaraco/skeleton#34. * Replace pep517.build with build (#37) * Replace pep517.build with build Resolves #30 * Prefer simple usage Co-authored-by: Jason R. Coombs <jaraco@jaraco.com> * Use license_files instead of license_file in meta (#35) Singular `license_file` is deprecated since wheel v0.32.0. Refs: * https://wheel.readthedocs.io/en/stable/news.html * https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
distutils: pass -rpath on macOS when requested
Originally reported by: jaraco (Bitbucket: jaraco, GitHub: jaraco)
I do regularly run the tests on Windows. Back around 0.6.21 or so, the tests were passing on Windows in totality. When I run the tests now, I get two failures in tests due to shebang lines in scripts (complete transcript):
I've been ignoring these test failures because I believe it is the tests that are broken and not the implementation. I suspect these tests will not fail when there is not a space in the path to python.exe.
The text was updated successfully, but these errors were encountered: