Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better cleanup PYTHONPATH for Mercurial calls (support for PDM) #1080

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

paugier
Copy link
Contributor

@paugier paugier commented Oct 23, 2024

PDM uses the same strategy as pip for the build isolation except that the path of the temporary directory starts with "pdm-build-env-" and not "pip-build-env-".

Therefore, Mercurial (a Python application) installations can be broken and we need to clean up PYTHONPATH from such paths.

Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if there is a good integration test for this

@paugier
Copy link
Contributor Author

paugier commented Oct 23, 2024

I don't think there is a specific test about this mechanism. However, setuptools_scm._run_cmd.run is executed during the tests. I guess that setuptools_scm is tested with an installation with pip. If it is the case, this line is covered.

A problem is that pep 517 does not specify how the frontends implement the isolated build (https://peps.python.org/pep-0517/#build-environment), so we can just try to avoid known issues.

@RonnyPfannschmidt RonnyPfannschmidt merged commit 3c145df into pypa:main Oct 24, 2024
18 checks passed
@paugier
Copy link
Contributor Author

paugier commented Oct 24, 2024

Thanks @RonnyPfannschmidt. Do you think a new version could be released on PyPI? I see that the last version was released on May 2024.

@RonnyPfannschmidt
Copy link
Contributor

I'll try, but no promises, I'm suffering a stomach infection

@paugier
Copy link
Contributor Author

paugier commented Oct 24, 2024

Oh I hope you will recover soon. Be brave.

I'm working on modernizing Mercurial setup.py and I'd like to try to use setuptools-scm. But of course your health is more important than open-source!

Beside, do not hesitate to tell me if I can help on anything for setuptools-scm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants